You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/04 10:46:27 UTC

[GitHub] [cordova-plugin-file] convey-gilbert opened a new pull request #259: feat(windows): known folders support

convey-gilbert opened a new pull request #259: feat(windows): known folders support
URL: https://github.com/apache/cordova-plugin-file/pull/259
 
 
   Access to known user folders:
   documentsDirectory: Documents, 
   picturesDirectory: Pictures,
   musicDirectory: Music,
   videoDirectory: Videos
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Windows
   
   ### What does this PR do?
   Add support for known folders. Essential feature that is needed to access any file outside of private app sandbox
   
   Limitation:
   > There is stil a problem, that working on known folders / file libraries like this will only work on Windows 10, not on 8.x
   (copied from comment below)
   
   ### What testing has been done on this change?
   Tested on Windows 10 Pro 1803 Build 17134.320
   
   ### Checklist
   - [ ] ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~
   - [ ] ~~Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.~~
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org