You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Daan Hoogland <da...@gmail.com> on 2018/01/03 13:47:04 UTC
test file sticking around
devs,
This has been bugging me but not enough to tackle: a file named
'services/secondary-storage/server/testfile' is created during the build
and I think it is created in
NfsSecondaryStorageResourceTest.testSwiftWriteMetadataFile(). I want to
solve this with an @After method. Any reason not to? like it being used in
more then just this test, or it should be destroyed in the test itself.
regards,
--
Daan
Re: test file sticking around
Posted by Daan Hoogland <da...@gmail.com>.
thanks guys,
I did it in an @After-method anyway to make sure it still gets cleaned on
exceptions.
enjoy https://github.com/apache/cloudstack/pull/2384
On Wed, Jan 3, 2018 at 3:27 PM, Rohit Yadav <ro...@shapeblue.com>
wrote:
> +1 remove after test finishes.
>
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
>
>
>
> ________________________________
> From: Daan Hoogland <da...@gmail.com>
> Sent: Wednesday, January 3, 2018 7:17:04 PM
> To: dev
> Subject: test file sticking around
>
> devs,
>
> This has been bugging me but not enough to tackle: a file named
> 'services/secondary-storage/server/testfile' is created during the build
> and I think it is created in
> NfsSecondaryStorageResourceTest.testSwiftWriteMetadataFile(). I want to
> solve this with an @After method. Any reason not to? like it being used in
> more then just this test, or it should be destroyed in the test itself.
>
> regards,
> --
> Daan
>
> rohit.yadav@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London WC2N 4HSUK
> @shapeblue
>
>
>
>
--
Daan
Re: test file sticking around
Posted by Rohit Yadav <ro...@shapeblue.com>.
+1 remove after test finishes.
- Rohit
<https://cloudstack.apache.org>
________________________________
From: Daan Hoogland <da...@gmail.com>
Sent: Wednesday, January 3, 2018 7:17:04 PM
To: dev
Subject: test file sticking around
devs,
This has been bugging me but not enough to tackle: a file named
'services/secondary-storage/server/testfile' is created during the build
and I think it is created in
NfsSecondaryStorageResourceTest.testSwiftWriteMetadataFile(). I want to
solve this with an @After method. Any reason not to? like it being used in
more then just this test, or it should be destroyed in the test itself.
regards,
--
Daan
rohit.yadav@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue
Re: test file sticking around
Posted by Rafael Weingärtner <ra...@gmail.com>.
+1 for removal.
Do you need to do this in the @After? If it is a single test method that is
creating this file, why not delete it after the assertions?
On Wed, Jan 3, 2018 at 11:47 AM, Daan Hoogland <da...@gmail.com>
wrote:
> devs,
>
> This has been bugging me but not enough to tackle: a file named
> 'services/secondary-storage/server/testfile' is created during the build
> and I think it is created in
> NfsSecondaryStorageResourceTest.testSwiftWriteMetadataFile(). I want to
> solve this with an @After method. Any reason not to? like it being used in
> more then just this test, or it should be destroyed in the test itself.
>
> regards,
> --
> Daan
>
--
Rafael Weingärtner