You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/12/17 17:39:30 UTC

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22225


Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................

[build-and-test] run 'gradle clean' before building Java

When updating Java dependencies in changelists [1] and [2], I noticed
that pre-commit builds were failing fail because the copyDistTestJars
task wouldn't copy all the necessary JARs to into the staging directory
for dist-test since gradle would assume the target is up-to-date.
I think that was due to the fact that the same workspace was re-used
between different builds, and no 'clean' task was run.

This changelist is to address the issue.  To avoid incurring the penalty
of rebuilding Java bits from scratch, this patch enables gradle's build
cache. As per [3], this is exactly the use-case to benefit from gradle's
caching.  In addition, this patch re-enables parallel builds as well.

[1] https://github.com/apache/kudu/commit/b009144cd
[2] https://github.com/apache/kudu/commit/150ec7ff5
[3] https://docs.gradle.org/current/userguide/part6_gradle_caching.html

Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Reviewed-on: http://gerrit.cloudera.org:8080/22144
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 91cb9da22c9437db2e8b4b0f2793aca081afddc1)
---
M build-support/jenkins/build-and-test.sh
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/22225/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................

[build-and-test] run 'gradle clean' before building Java

When updating Java dependencies in changelists [1] and [2], I noticed
that pre-commit builds were failing fail because the copyDistTestJars
task wouldn't copy all the necessary JARs to into the staging directory
for dist-test since gradle would assume the target is up-to-date.
I think that was due to the fact that the same workspace was re-used
between different builds, and no 'clean' task was run.

This changelist is to address the issue.  To avoid incurring the penalty
of rebuilding Java bits from scratch, this patch enables gradle's build
cache. As per [3], this is exactly the use-case to benefit from gradle's
caching.  In addition, this patch re-enables parallel builds as well.

[1] https://github.com/apache/kudu/commit/b009144cd
[2] https://github.com/apache/kudu/commit/150ec7ff5
[3] https://docs.gradle.org/current/userguide/part6_gradle_caching.html

Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Reviewed-on: http://gerrit.cloudera.org:8080/22144
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 91cb9da22c9437db2e8b4b0f2793aca081afddc1)
Reviewed-on: http://gerrit.cloudera.org:8080/22225
---
M build-support/jenkins/build-and-test.sh
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2024 02:48:21 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Patch Set 1: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/842/


-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2024 00:25:52 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/842/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2024 01:41:24 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Patch Set 1: Verified+1

unrelated test failures:
  * DEBUG: BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirsFuzz/4 (see KUDU-3591)
  * ASAN: org.apache.kudu.client.TestKuduTransaction


-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2024 03:00:25 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/839/


-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Dec 2024 17:39:40 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) [build-and-test] run 'gradle clean' before building Java

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22225 )

Change subject: [build-and-test] run 'gradle clean' before building Java
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/839/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3d2f07dfcf8746aa69f870c319599c92e098dc
Gerrit-Change-Number: 22225
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Dec 2024 18:52:36 +0000
Gerrit-HasComments: No