You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "kovaxur (via GitHub)" <gi...@apache.org> on 2023/10/26 08:46:31 UTC

[PR] feat: added global labelselector feature for podmonitors [pulsar-helm-chart]

kovaxur opened a new pull request, #402:
URL: https://github.com/apache/pulsar-helm-chart/pull/402

   Fixes #401 
   
   ### Motivation
   
   We are using grafana-agent, which uses label selector for podMonitors, so we need to be able to set custom labels on the podMonitors resources.
   
   ### Modifications
   
   Added a global variable to set custom labels for all podMonitors. If someone needs more granular label setting, it needs to be implemented for each service.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: added global labelselector feature for podmonitors [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #402:
URL: https://github.com/apache/pulsar-helm-chart/pull/402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: added global labelselector feature for podmonitors [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #402:
URL: https://github.com/apache/pulsar-helm-chart/pull/402#issuecomment-4089519629

   @kovaxur Please rebase. The pod monitors changed in #592


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org