You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/08/28 16:38:27 UTC
[GitHub] nifi-minifi-cpp pull request #393: MINIFICPP 601: Add Scheduling information
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/393
MINIFICPP 601: Add Scheduling information
This is predicated upon #392
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #393
----
commit 7ac309ba76813e5dbdb1e1857da4c6115a4c2fd1
Author: Marc Parisi <ph...@...>
Date: 2018-08-20T16:26:14Z
MINIFICPP-598: Add relationship support into manifest
MINIFICPP-600: Add default value into property descriptors
commit 30a19a1c73c244352178b165acc7d29728df881a
Author: Marc Parisi <ph...@...>
Date: 2018-08-22T00:22:57Z
MINIFICPP-601: Add scheduling information
----
---
[GitHub] nifi-minifi-cpp issue #393: MINIFICPP 601: Add Scheduling information
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/393
@phrocker would you mind please rebasing this on master? I unfortunately missed the PR coming when reviewing #392. The merge conflicts look relatively straightforward but I don't want to overlook something in that process
---
[GitHub] nifi-minifi-cpp pull request #393: MINIFICPP 601: Add Scheduling information
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/393#discussion_r213437908
--- Diff: bootstrap.sh ---
@@ -25,6 +25,7 @@ CORES=1
BUILD="false"
PACKAGE="false"
BUILD_IDENTIFIER=""
+BUILD_IDENTIFIER=""
--- End diff --
Will clean this up on merge
---
[GitHub] nifi-minifi-cpp pull request #393: MINIFICPP 601: Add Scheduling information
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/393
---