You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ko...@apache.org on 2014/09/18 14:01:32 UTC
git commit: updated refs/heads/master to 4e07dd1
Repository: cloudstack
Updated Branches:
refs/heads/master 7f440854f -> 4e07dd1dc
CLOUDSTACK-7581: Empty 'ID' parameters allowed in API calls
Fix is to fail API calls with empty 'id' parameter value upfront rather than going ahead and failing with NPE later on
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/4e07dd1d
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/4e07dd1d
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/4e07dd1d
Branch: refs/heads/master
Commit: 4e07dd1dc4b4618fff2ef25c846ce6b95a8e580d
Parents: 7f44085
Author: Koushik Das <ko...@apache.org>
Authored: Thu Sep 18 17:10:25 2014 +0530
Committer: Koushik Das <ko...@apache.org>
Committed: Thu Sep 18 17:10:25 2014 +0530
----------------------------------------------------------------------
server/src/com/cloud/api/dispatch/ParamProcessWorker.java | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/4e07dd1d/server/src/com/cloud/api/dispatch/ParamProcessWorker.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/dispatch/ParamProcessWorker.java b/server/src/com/cloud/api/dispatch/ParamProcessWorker.java
index 9a98f33..ff6d666 100644
--- a/server/src/com/cloud/api/dispatch/ParamProcessWorker.java
+++ b/server/src/com/cloud/api/dispatch/ParamProcessWorker.java
@@ -329,8 +329,6 @@ public class ParamProcessWorker implements DispatchWorker {
field.set(cmdObj, listParam);
break;
case UUID:
- if (paramObj.toString().isEmpty())
- break;
final Long internalId = translateUuidToInternalId(paramObj.toString(), annotation);
field.set(cmdObj, internalId);
break;