You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/06/13 06:23:48 UTC
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2316: Fix NLIP receives
apache-mynewt-bot commented on pull request #2316:
URL: https://github.com/apache/mynewt-core/pull/2316#issuecomment-643577884
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### encoding/base64/src/base64.c
<details>
```diff
@@ -131,19 +135,22 @@
int i;
unsigned int val = 0;
int marker = 0;
- if (len < 4)
+ if (len < 4) {
return DECODE_ERROR;
+ }
for (i = 0; i < 4; i++) {
val *= 64;
- if (token[i] == '=')
+ if (token[i] == '=') {
marker++;
- else if (marker > 0)
+ } else if (marker > 0) {
return DECODE_ERROR;
- else
+ } else {
val += pos(token[i]);
- }
- if (marker > 2)
+ }
+ }
+ if (marker > 2) {
return DECODE_ERROR;
+ }
return (marker << 24) | val;
}
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org