[jira] [Commented] (HIVE-13628) Support for permanent functions - error handling if no restart

["Gunther Hagleitner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262982#comment-15262982 ] 

Gunther Hagleitner commented on HIVE-13628:
-------------------------------------------

Cool. Couple of minor recommendations:

a.)

{noformat}
if (LlapProxy.isDaemon()) { // daemon
{noformat}

might be a better check than just configuration.

b.) 

{noformat}
import sun.tools.java.ClassNotFound;
{noformat}

is not needed, is it?

c.)

The message should be qualified by a "maybe" i think. It's still possible that there's something else that is wrong. I think it should say something like. "Missing class "XXX". If this a UDF and you're running llap, you might require ..."

Otherwise +1 pending tests.

> Support for permanent functions - error handling if no restart
> --------------------------------------------------------------
>
>                 Key: HIVE-13628
>                 URL: https://issues.apache.org/jira/browse/HIVE-13628
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 2.1.0
>            Reporter: Vikram Dixit K
>            Assignee: Vikram Dixit K
>         Attachments: HIVE-13628.1.patch
>
>
> Support for permanent functions - error handling if no restart



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)