You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/15 08:12:00 UTC
[GitHub] [flink] zekai-li opened a new pull request, #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
zekai-li opened a new pull request, #21675:
URL: https://github.com/apache/flink/pull/21675
- java document {@link} is incorrectly used
- The Chinese document stream kafka connect has a spelling error
- An error spelling flink as fink occurred in FlinkSqlParserImplTest
Details are available at https://issues.apache.org/jira/browse/FLINK-30690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105339358
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1427522105
Please check the CI pipeline, it seems the `FlinkSqlParserImplTest.testCreateFunction` failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xianyu110 commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by GitBox <gi...@apache.org>.
xianyu110 commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1383103546
constant attention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1104129280
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
Why add these two items? Will the test fail without this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105980571
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
Thank you for the investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1428996963
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105179968
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
When the rat-plugin scans the license at compile time, it will scan these files and cause errors, but these files do not require the license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105338820
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
When I remove these exceptions locally, I get an error when I compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1429008467
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105534061
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
My maven version is v3.6.3 ,OS windows10 , I tried v3.2.5 but it didn't work，Report the same error as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105606819
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
public static boolean isBinary(InputStream in) {
try {
byte[] taste = new byte[200];
int bytesRead = in.read(taste);
if (bytesRead > 0) {
ByteBuffer bytes = ByteBuffer.wrap(taste, 0, bytesRead);
CharBuffer chars = CharBuffer.allocate(2 * bytesRead);
CharsetDecoder cd = CHARSET_FROM_FILE_ENCODING_OR_UTF8.newDecoder()
.onMalformedInput(CodingErrorAction.REPORT)
.onUnmappableCharacter(CodingErrorAction.REPORT);
while (bytes.remaining() > 0) {
CoderResult res = cd.decode(bytes, chars, true);
if (res.isMalformed() || res.isUnmappable()) {
return true;
} else if (res.isOverflow()) {
chars.limit(chars.position());
chars.rewind();
int c = chars.capacity() * 2;
CharBuffer on = CharBuffer.allocate(c);
on.put(chars);
chars = on;
}
}
chars.limit(chars.position());
chars.rewind();
return isBinary(chars);
}
} catch (IOException e) {
// SWALLOW
}
return false;
}
static Charset getFileEncodingOrUTF8AsFallback() {
try {
return Charset.forName(System.getProperty(FILE_ENCODING));
} catch (UnsupportedCharsetException e) {
return Charset.forName("UTF-8");
}
}
This is the code of rat-plugin to check whether the file is binary file. I doubt that it should be checked out in UNIx-like system, but on windows, the check is non-binary file, the specific class is in org.apache.rat.document.impl.guesser.BinaryGuesser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1426032058
> The compile build failed. Could you fix it first?
The compilation error has been fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1428954357
>
All right, I'll check this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105534061
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
My maven version is v3.6.3, I tried v3.2.5 but it didn't work，Report the same error as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105708404
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
There you have it. Because the default character set for windows cmd is GBK, most files are treated as non-binary files. Unix-like so far all I've seen is utf-8 so I can tell the binaries. In order to be out of the box for users, it is recommended that these exclusions be added. Alternatively -Dfile.encoding=UTF-8 on mvnw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1425376237
The compile build failed. Could you fix it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1425543867
> The compile build failed. Could you fix it first?
Ok, I'll try to fix the compilation error here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1426034122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong merged PR #21675:
URL: https://github.com/apache/flink/pull/21675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1429936935
Rebased and squashed commits to trigger the CI again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105409570
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
Which maven version are you using? Could you try v3.2.5 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105249581
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
These files have been added for a long time, and the master build is always passing. I don't understand why it failed in your case. Could you try to remove the changes and see if the tests fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105384852
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
Possible problems with the actual version of the plugin in azure? Or is there any special configuration? I tried to use the ci configuration but still got an error. Personally, I think these files should be excluded regardless of whether errors are reported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zekai-li commented on a diff in pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by "zekai-li (via GitHub)" <gi...@apache.org>.
zekai-li commented on code in PR #21675:
URL: https://github.com/apache/flink/pull/21675#discussion_r1105534061
##########
pom.xml:
##########
@@ -1500,6 +1500,8 @@ under the License.
<exclude>flink-formats/flink-avro/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-scala/src/test/resources/flink_11-kryo_registrations</exclude>
<exclude>flink-core/src/test/resources/kryo-serializer-config-snapshot-v1</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field</exclude>
+ <exclude>flink-core/src/test/resources/abstractID-with-toString-field-set</exclude>
Review Comment:
My maven version is v3.6.3, I tried v3.2.5 but it didn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21675: [FLINK-30690][javadocs][spelling] Fix java documentation and some wor…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21675:
URL: https://github.com/apache/flink/pull/21675#issuecomment-1383085854
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fef9d04a7df657c6267b0c0384190e2932de502a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fef9d04a7df657c6267b0c0384190e2932de502a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fef9d04a7df657c6267b0c0384190e2932de502a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org