You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 03:45:51 UTC

[GitHub] [arrow-datafusion] turbo1912 opened a new pull request, #3102: Remove offset if its zero

turbo1912 opened a new pull request, #3102:
URL: https://github.com/apache/arrow-datafusion/pull/3102

   # Which issue does this PR close?
   
   Closes #2584 
   
    # Rationale for this change
   If offset is 0, it should be a no-op and can be optimized out. 
   
   Questions to the reviewer? 
   Current proposed change adds this optimization to an existing slightly related optimizer. Does this require its own optimizer independent from eliminate_limit?  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #3102: Remove offset if its zero

Posted by GitBox <gi...@apache.org>.
alamb merged PR #3102:
URL: https://github.com/apache/arrow-datafusion/pull/3102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #3102: Remove offset if its zero

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3102:
URL: https://github.com/apache/arrow-datafusion/pull/3102#issuecomment-1212515186

   Benchmark runs are scheduled for baseline = 9956f80f197550051db7debae15d5c706afc22a3 and contender = dbfb0e6ff9bc6fb933ed7cfd15bd9127ac0d443a. dbfb0e6ff9bc6fb933ed7cfd15bd9127ac0d443a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e719e2927b0e4f74a57a5e0fed78c3ec...f7c0f7a25c834c7b8610f4905d5e0444/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1e5e63eec13a4d9ea32e4a20fc73942f...44181ed8c8ba462081822b10ad0c7134/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6286264d8af14f12973327fc1133905b...58c48881d81b41a1a9a36d6ec785b9f4/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/172cbc10d09b4290b7b0b21dadfdc757...7d73147f25554b68b0935746fa706381/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #3102: Remove offset if its zero

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3102:
URL: https://github.com/apache/arrow-datafusion/pull/3102#issuecomment-1212512785

   Nice -- thanks @turbo1912 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3102: Remove offset if its zero

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3102:
URL: https://github.com/apache/arrow-datafusion/pull/3102#issuecomment-1211535809

   # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3102](https://codecov.io/gh/apache/arrow-datafusion/pull/3102?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f660acb) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/85d53634c4d26a3b9e545878e377860c14d01d7d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85d5363) will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #3102      +/-   ##
   ==========================================
   + Coverage   85.93%   85.95%   +0.01%     
   ==========================================
     Files         289      290       +1     
     Lines       52101    52270     +169     
   ==========================================
   + Hits        44774    44929     +155     
   - Misses       7327     7341      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3102?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [datafusion/optimizer/src/eliminate\_limit.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL2VsaW1pbmF0ZV9saW1pdC5ycw==) | `100.00% <100.00%> (ø)` | |
   | [.../core/src/physical\_plan/file\_format/file\_stream.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L2ZpbGVfc3RyZWFtLnJz) | `88.88% <0.00%> (-1.59%)` | :arrow_down: |
   | [datafusion/expr/src/window\_frame.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy93aW5kb3dfZnJhbWUucnM=) | `92.43% <0.00%> (-0.85%)` | :arrow_down: |
   | [...tafusion/core/src/physical\_plan/file\_format/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L21vZC5ycw==) | `96.95% <0.00%> (-0.42%)` | :arrow_down: |
   | [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.60% <0.00%> (-0.35%)` | :arrow_down: |
   | [datafusion/core/src/dataframe.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9kYXRhZnJhbWUucnM=) | `88.86% <0.00%> (-0.20%)` | :arrow_down: |
   | [...sion/core/src/physical\_plan/file\_format/parquet.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L3BhcnF1ZXQucnM=) | `95.34% <0.00%> (-0.12%)` | :arrow_down: |
   | [datafusion/optimizer/src/simplify\_expressions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3NpbXBsaWZ5X2V4cHJlc3Npb25zLnJz) | `83.94% <0.00%> (-0.09%)` | :arrow_down: |
   | [datafusion/expr/src/binary\_rule.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9iaW5hcnlfcnVsZS5ycw==) | `84.61% <0.00%> (-0.05%)` | :arrow_down: |
   | [datafusion/expr/src/columnar\_value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9jb2x1bW5hcl92YWx1ZS5ycw==) | `100.00% <0.00%> (ø)` | |
   | ... and [17 more](https://codecov.io/gh/apache/arrow-datafusion/pull/3102/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #3102: Remove offset if its zero

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3102:
URL: https://github.com/apache/arrow-datafusion/pull/3102#issuecomment-1212005349

   LGTM @turbo1912. Could you update the rustdoc at the top of the file now that this optimizes both limits and offsets? I think it makes sense for these related optimizations to be in the same rule. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org