You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2014/08/23 19:58:54 UTC
[1/3] git commit: HBASE-11794 StripeStoreFlusher causes
NullPointerException (jeongmin kim)
Repository: hbase
Updated Branches:
refs/heads/0.98 974689842 -> b99e2b3e6
refs/heads/branch-1 08c14bd50 -> 01e4f0ed8
refs/heads/master f69a1945c -> 368aee62a
HBASE-11794 StripeStoreFlusher causes NullPointerException (jeongmin kim)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/368aee62
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/368aee62
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/368aee62
Branch: refs/heads/master
Commit: 368aee62af74fcae5a6a00253c0f6ea74a11b194
Parents: f69a194
Author: Andrew Purtell <ap...@apache.org>
Authored: Sat Aug 23 10:49:21 2014 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Sat Aug 23 10:49:21 2014 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/regionserver/StripeStoreFlusher.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/368aee62/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
index 768c691..ae34799 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
@@ -21,6 +21,7 @@ package org.apache.hadoop.hbase.regionserver;
import static org.apache.hadoop.hbase.regionserver.StripeStoreFileManager.OPEN_KEY;
import java.io.IOException;
+import java.util.ArrayList;
import java.util.List;
import org.apache.commons.logging.Log;
@@ -54,7 +55,7 @@ public class StripeStoreFlusher extends StoreFlusher {
@Override
public List<Path> flushSnapshot(MemStoreSnapshot snapshot, long cacheFlushSeqNum,
MonitoredTask status) throws IOException {
- List<Path> result = null;
+ List<Path> result = new ArrayList<Path>();
int cellsCount = snapshot.getCellsCount();
if (cellsCount == 0) return result; // don't flush if there are no entries
@@ -83,9 +84,6 @@ public class StripeStoreFlusher extends StoreFlusher {
}
} finally {
if (!success && (mw != null)) {
- if (result != null) {
- result.clear();
- }
for (Path leftoverFile : mw.abortWriters()) {
try {
store.getFileSystem().delete(leftoverFile, false);
[2/3] git commit: HBASE-11794 StripeStoreFlusher causes
NullPointerException (jeongmin kim)
Posted by ap...@apache.org.
HBASE-11794 StripeStoreFlusher causes NullPointerException (jeongmin kim)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/01e4f0ed
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/01e4f0ed
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/01e4f0ed
Branch: refs/heads/branch-1
Commit: 01e4f0ed8ae1ccf2fefee395fcc3247f18d61fc3
Parents: 08c14bd
Author: Andrew Purtell <ap...@apache.org>
Authored: Sat Aug 23 10:49:21 2014 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Sat Aug 23 10:49:33 2014 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/regionserver/StripeStoreFlusher.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/01e4f0ed/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
index 768c691..ae34799 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
@@ -21,6 +21,7 @@ package org.apache.hadoop.hbase.regionserver;
import static org.apache.hadoop.hbase.regionserver.StripeStoreFileManager.OPEN_KEY;
import java.io.IOException;
+import java.util.ArrayList;
import java.util.List;
import org.apache.commons.logging.Log;
@@ -54,7 +55,7 @@ public class StripeStoreFlusher extends StoreFlusher {
@Override
public List<Path> flushSnapshot(MemStoreSnapshot snapshot, long cacheFlushSeqNum,
MonitoredTask status) throws IOException {
- List<Path> result = null;
+ List<Path> result = new ArrayList<Path>();
int cellsCount = snapshot.getCellsCount();
if (cellsCount == 0) return result; // don't flush if there are no entries
@@ -83,9 +84,6 @@ public class StripeStoreFlusher extends StoreFlusher {
}
} finally {
if (!success && (mw != null)) {
- if (result != null) {
- result.clear();
- }
for (Path leftoverFile : mw.abortWriters()) {
try {
store.getFileSystem().delete(leftoverFile, false);
[3/3] git commit: HBASE-11794 StripeStoreFlusher causes
NullPointerException (jeongmin kim)
Posted by ap...@apache.org.
HBASE-11794 StripeStoreFlusher causes NullPointerException (jeongmin kim)
Amending-Author: Andrew Purtell <ap...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b99e2b3e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b99e2b3e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b99e2b3e
Branch: refs/heads/0.98
Commit: b99e2b3e65e8fbed5b3d66ae0d3e0c5d40b82923
Parents: 9746898
Author: Andrew Purtell <ap...@apache.org>
Authored: Sat Aug 23 10:49:21 2014 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Sat Aug 23 10:53:42 2014 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/regionserver/StripeStoreFlusher.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/b99e2b3e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
index a2ece5d..93e859a 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeStoreFlusher.java
@@ -60,7 +60,7 @@ public class StripeStoreFlusher extends StoreFlusher {
public List<Path> flushSnapshot(SortedSet<KeyValue> snapshot, long cacheFlushSeqNum,
final TimeRangeTracker tracker, AtomicLong flushedSize, MonitoredTask status)
throws IOException {
- List<Path> result = null;
+ List<Path> result = new ArrayList<Path>();
int kvCount = snapshot.size();
if (kvCount == 0) return result; // don't flush if there are no entries
@@ -89,9 +89,6 @@ public class StripeStoreFlusher extends StoreFlusher {
}
} finally {
if (!success && (mw != null)) {
- if (result != null) {
- result.clear();
- }
for (Path leftoverFile : mw.abortWriters()) {
try {
store.getFileSystem().delete(leftoverFile, false);