You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/07/10 17:51:38 UTC
[GitHub] [camel] essobedo opened a new pull request, #10648: incremental-build - Replace quick-test with incremental test
essobedo opened a new pull request, #10648:
URL: https://github.com/apache/camel/pull/10648
## Motivation
The Quick test is not able to test the projects that depend on the directly affected projects such that we need to manually specify the components to test whereas the incremental test is capable of testing projects that depend on the affected project too.
## Modifications:
* Replace the quick test with the incremental test
* Remove the `component-test` github action since it is no more needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #10648: incremental-build - Replace quick-test with incremental test
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #10648:
URL: https://github.com/apache/camel/pull/10648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10648: incremental-build - Replace quick-test with incremental test
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10648:
URL: https://github.com/apache/camel/pull/10648#issuecomment-1630259540
> @orpiske WDYT of it? As you are the code owner of the Quick Test, I would like to have your point of view before going any further. If you prefer to keep the Quick Test then let's simply remove the incremental build as it doesn't make sense anymore, it could only make sense for the tests.
I am OK with the idea of consolidating into one or another. I do have a few questions:
- Do we still retain the test summary, so we can view what failed with ease?
- Do we still archive the logs, so we can investigate what has failed?
- Can we adjust the incremental build/test to comment on the PR with failed status and so on, so both we and the contributors know what has failed?
To be clear: none of these would be blocking items ... I'm just trying to understand to which extent we can make the build reports from the incremental one easier for us and the contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10648: incremental-build - Replace quick-test with incremental test
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10648:
URL: https://github.com/apache/camel/pull/10648#issuecomment-1629447684
@orpiske WDYT of it? As you are the code owner of the Quick Test, I would like to have your point of view before going any further. If you prefer to keep the Quick Test then let's simply remove the incremental build as it doesn't make sense anymore, it could only make sense for the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10648: incremental-build - Replace quick-test with incremental test
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10648:
URL: https://github.com/apache/camel/pull/10648#issuecomment-1630284052
> * Do we still retain the test summary, so we can view what failed with ease?
It could be improved to add more info but I personally believe that it is quite controversial. Indeed, TBH as a contributor, if the tests pass, I don't really need a comment indicating that the tests passed. For me, it is more like spam than real info because you get this comment for each existing PRs which means more emails received for no real value. IMHO the only potential value is to be notified when the tests ended if you want to merge it quickly but it should not happen so often. And when the tests fail, I know that I will need to check the log anyway, knowing which component failed only makes sense with the quick test as you have different log files IIRC.
But it is only my point of view if other committers find this info helpful, I can try to add it if needed in the incremental test
> * Do we still archive the logs, so we can investigate what has failed?
Yes of course
> * Can we adjust the incremental build/test to comment on the PR with failed status and so on, so both we and the contributors know what has failed?
See above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10648: incremental-build - Replace quick-test with incremental test
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10648:
URL: https://github.com/apache/camel/pull/10648#issuecomment-1630331553
@orpiske Fair enough, thx 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org