You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "krashouk (via GitHub)" <gi...@apache.org> on 2026/08/11 15:12:13 UTC

[PR] [ISSUE #1890] 应用关闭时停止集群缓存调度器 [rocketmq-dashboard]

krashouk opened a new pull request, #1900:
URL: https://github.com/apache/rocketmq-dashboard/pull/1900

   ## 变更目的
   
   ClusterInfoService 创建的 ScheduledExecutorService 没有销毁入口，应用上下文关闭后线程仍可能存活。
   
   ## 简要变更
   
   - 增加 Jakarta `@PreDestroy` 生命周期方法。
   - 销毁时调用 `scheduler.shutdown()`，不强制中断正在执行的刷新。
   - 增加调度器关闭状态回归测试。
   
   ## 本地验证
   
   - `ClusterInfoServiceTest`：1/1 通过（Temurin 17）
   - `git diff --check`：通过
   - 400 行范围门禁：通过
   
   ## 未执行
   
   未运行容器、RocketMQ 集群、完整 E2E、压力测试或镜像构建；这些重量级验证交由 PR 自动触发的上游检查。
   
   ## 提交清单
   
   - [x] 已创建唯一对应 Issue
   - [x] 一个 PR 只解决一个问题
   - [x] 已增加必要回归测试
   - [x] 已完成受影响范围的本地轻量验证
   
   Fixes #1890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #1890] 应用关闭时停止集群缓存调度器 [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1900:
URL: https://github.com/apache/rocketmq-dashboard/pull/1900#issuecomment-5278419296

   Closing: this PR targets the legacy dashboard codebase (old src/ / frontend-new directories), which is no longer maintained. Development has moved to the new Studio architecture (server/ + web/), with the transition expected to complete in September. Thanks for the contribution — if the issue still applies to the new Studio, please feel free to open a new PR against the current structure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #1890] 应用关闭时停止集群缓存调度器 [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1900: [ISSUE #1890] 应用关闭时停止集群缓存调度器
URL: https://github.com/apache/rocketmq-dashboard/pull/1900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org