Re: [PR] chore: Deprecate stream testkit's probe methods [pekko]

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #2439:
URL: https://github.com/apache/pekko/pull/2439#discussion_r2504871635


##########
stream-testkit/src/main/scala/org/apache/pekko/stream/testkit/javadsl/TestSource.scala:
##########
@@ -23,15 +23,15 @@ import pekko.stream.testkit._
 object TestSource {
 
   /**
-   * A Source that materializes to a [[pekko.stream.testkit.TestPublisher.Probe]].
+   * A Source that materializes to a [[pekko.stream.testkit.TestPublisher]].
    */
-  def probe[T](system: ActorSystem): Source[T, TestPublisher.Probe[T]] =
-    new Source(scaladsl.TestSource.probe[T](system))
+  @deprecated("Use `TestSource.create` with ClassicActorSystemProvider instead of ActorSystem", "1.3.0")

Review Comment:
   may be better to also add Java `@Deprecated` annotation and add `@deprecated Use `TestSource.create` with ClassicActorSystemProvider instead of ActorSystem (since 1.3.0)` to the Javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org