You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2024/07/08 10:07:48 UTC
[PR] Upgrade vcpkg folly version to 2024.05.20.00 [incubator-gluten]
boneanxs opened a new pull request, #6372:
URL: https://github.com/apache/incubator-gluten/pull/6372
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Since velox update the fbos version to 2024.05.20.00 from this pr: https://github.com/facebookincubator/velox/pull/9968, we better update vcpkg as well to align the change
(Fixes: \#ISSUE-ID)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Upgrade vcpkg folly version to 2024.05.20.00 [incubator-gluten]
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on PR #6372:
URL: https://github.com/apache/incubator-gluten/pull/6372#issuecomment-2222109798
Close this in favor of https://github.com/apache/incubator-gluten/pull/6401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Upgrade vcpkg folly version to 2024.05.20.00 [incubator-gluten]
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on PR #6372:
URL: https://github.com/apache/incubator-gluten/pull/6372#issuecomment-2219446319
Hey @PHILO-HE @zhouyuan , can you help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Upgrade vcpkg folly version to 2024.05.20.00 [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #6372:
URL: https://github.com/apache/incubator-gluten/pull/6372#issuecomment-2220211816
@boneanxs thanks for helping on this, it seems the build failed due to low disk space in github runner, will try to make a new docker image it include this fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] Upgrade vcpkg folly version to 2024.05.20.00 [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6372:
URL: https://github.com/apache/incubator-gluten/pull/6372#issuecomment-2213595226
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Upgrade vcpkg folly version to 2024.05.20.00 [incubator-gluten]
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs closed pull request #6372: [VL] Upgrade vcpkg folly version to 2024.05.20.00
URL: https://github.com/apache/incubator-gluten/pull/6372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org