[Issue 124580] New: PageShadow sometimes shows gaps

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=124580

          Issue ID: 124580
        Issue Type: DEFECT
           Summary: PageShadow sometimes shows gaps
           Product: Draw
           Version: 4.1.0-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: viewing
          Assignee: issues@openoffice.apache.org
          Reporter: Armin.Le.Grand@me.com

In the migration to double precision (seen in aw080 but also in master) values
we have places in vcl where based on double translation and scale the integer
Point and Size need to be created. Up to now a direct basegfx::fround was used
for this, but this can be wrong for the Size. It is more precise (and may give
a different integer result) when using basegfx::fround(translation + scale) and
substractiong the already rounded Point. This is because the target position
where the double addition lands is the correct position to round where the pure
scale values may round based on different (and in this case wrong) unit buckets
(always from ]v-0.5 .. v+0.5] when using basegfx::fround).
This visualizes in sometimes appearing single-pixel sized 'gaps' in the page
shadow (just open new draw/impress and play with zoom, watch page shadow, esp.
in the edges since there different bitmaps get glued).

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 124580] PageShadow sometimes shows gaps

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=124580

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |
   Target Milestone|---                         |4.2.0

--- Comment #1 from Armin Le Grand <Ar...@me.com> ---
Grepping, preparing...

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 124580] PageShadow sometimes shows gaps

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=124580

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
Okay, corercted places where a metric item (a distance) was directly converted,
but in principle the max position was intended. Commited, done.

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 124580] PageShadow sometimes shows gaps

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=124580

--- Comment #2 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1583969 into trunk:
i124580 corrected some conversions of scale values to integer positions

-- 
You are receiving this mail because:
You are watching all issue changes.