You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/12/05 16:00:00 UTC
[jira] [Commented] (GEODE-7520) Don't run clang-format in regular
build steps
[ https://issues.apache.org/jira/browse/GEODE-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988932#comment-16988932 ]
ASF subversion and git services commented on GEODE-7520:
--------------------------------------------------------
Commit 3ad4257f6ba624b28145c6be5c932052ab261219 in geode-native's branch refs/heads/develop from Blake Bender
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=3ad4257 ]
GEODE-7520: Add convenient target to clangformat everything (#558)
- Add target 'all-clangformat' so we can easily reformat the entire tree
- Add a section about clang-format to BUILDING.md. Explain how to disable it, and also how to run it for all targets
> Don't run clang-format in regular build steps
> ---------------------------------------------
>
> Key: GEODE-7520
> URL: https://issues.apache.org/jira/browse/GEODE-7520
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Assignee: Blake Bender
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> *We should* stop running clang-format as part of the "build" step in all CI build pipelines
> *Because* Visual Studio ships with _broken_ versions of clang-format from time to time that crash while formatting our code, and this kills the Windows build job.
> We already have an agreed-upon version of clang-format, it's already running on Travis CI for pull requests _and_ in private CI pipelines, we do _not_ need it to be run for all flavors on all platforms every time we push to a branch with a private pipeline or to a release branch or to develop. To fix this properly, once and for all, we should:
> i. disable clang-format in the build step for all flavors of all pipelines
> ii. Create a separate clang-format job in all pipelines for _one_ flavor, e.g. Ubuntu Debug
> iii. Create an (optional) git commit hook for developers to use that will _not allow you to push_ with outstanding formatting changes.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)