[GitHub] [iceberg] jackye1995 commented on a diff in pull request #4428: Core, API: Add refs/ref methods to Table

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #4428:
URL: https://github.com/apache/iceberg/pull/4428#discussion_r883308674


##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -156,6 +156,16 @@ public List<HistoryEntry> history() {
     return table().history();
   }
 
+  @Override
+  public SnapshotRef ref(String ref) {

Review Comment:
   feels a bit awkward for metadata table to have refs... but given the fact that we are just mapping this to methods of the source `table()` for all the other methods, this seems to be the only way to do it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org