[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #650: JNDI enablement properties are loaded at most once

[GitBox <gi...@apache.org>]

garydgregory edited a comment on pull request #650:
URL: https://github.com/apache/logging-log4j2/pull/650#issuecomment-999846809


   How is that going to work for tests that set and clear properties? You
   don't want to set a property "forever"...
   
   Gary 
   
   On Wed, Dec 22, 2021, 15:25 Carter Kozak ***@***.***> wrote:
   
   > Rather than checking properties after each invocation, jndi
   > properties are all read into static final boolean fields when
   > the JndiManager class is initialized, this way properties cannot
   > be mutated and refreshed at runtime, and checks are cheaper.
   > This format matches other log4j configuration points as set
   > in Constants.java.
   > ------------------------------
   > You can view, comment on, or merge this pull request online at:
   >
   >   https://github.com/apache/logging-log4j2/pull/650
   > Commit Summary
   >
   >    - 8b627f9
   >    <https://github.com/apache/logging-log4j2/pull/650/commits/8b627f97c8f4a6b29c1ff1c272394d6ed932601e>
   >    JNDI enablement properties are loaded at most once
   >
   > File Changes
   >
   > (1 file <https://github.com/apache/logging-log4j2/pull/650/files>)
   >
   >    - *M*
   >    log4j-core/src/main/java/org/apache/logging/log4j/core/net/JndiManager.java
   >    <https://github.com/apache/logging-log4j2/pull/650/files#diff-271353c1076e53f6893261e4420de27d34588bfd782806b5c66a3465c43b7f51>
   >    (10)
   >
   > Patch Links:
   >
   >    - https://github.com/apache/logging-log4j2/pull/650.patch
   >    - https://github.com/apache/logging-log4j2/pull/650.diff
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/logging-log4j2/pull/650>, or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAJB6N3QMN24IMYUIZL7A6LUSIX5LANCNFSM5KTKMN7A>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because your review was requested.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org