You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 11:13:59 UTC
[GitHub] [airflow] ashb opened a new pull request, #25822: Don't use Pandas for SQLTableCheckOperator
ashb opened a new pull request, #25822:
URL: https://github.com/apache/airflow/pull/25822
Pandas is an optional extra for common-sql provider, so _forcing_ it for
a query that is going to return a couple of rows is not a good idea.
(We didn't notice this in CI as our tests have everyting installed)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] norm commented on a diff in pull request #25822: Don't use Pandas for SQLTableCheckOperator
Posted by GitBox <gi...@apache.org>.
norm commented on code in PR #25822:
URL: https://github.com/apache/airflow/pull/25822#discussion_r950186390
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -385,17 +385,15 @@ def execute(self, context: 'Context'):
self.sql = f"SELECT check_name, check_result FROM ({checks_sql}) "
f"AS check_table {partition_clause_statement};"
- records = hook.get_pandas_df(self.sql)
+ records = hook.get_records(self.sql)
Review Comment:
Did you forget to commit something? Tests fail:
> \> records = hook.get_records(self.sql)
> E AttributeError: 'MockHook' object has no attribute 'get_records'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25822: Don't use Pandas for SQLTableCheckOperator
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25822:
URL: https://github.com/apache/airflow/pull/25822#issuecomment-1220551386
/cc @eladkal @potiuk @denimalpaca
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #25822: Don't use Pandas for SQLTableCheckOperator
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #25822:
URL: https://github.com/apache/airflow/pull/25822#discussion_r950190654
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -385,17 +385,15 @@ def execute(self, context: 'Context'):
self.sql = f"SELECT check_name, check_result FROM ({checks_sql}) "
f"AS check_table {partition_clause_statement};"
- records = hook.get_pandas_df(self.sql)
+ records = hook.get_records(self.sql)
Review Comment:
No, I just failed to run the rest of the tests (I only checked my new test that hits a _real_ DB that I added in a paralell PR not the mocked one.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #25822: Don't use Pandas for SQLTableCheckOperator
Posted by GitBox <gi...@apache.org>.
ashb merged PR #25822:
URL: https://github.com/apache/airflow/pull/25822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org