Re: svn commit: r1297284 [1/2] - in /xmlgraphics/fop/trunk: ./ src/codegen/unicode/java/org/apache/fop/complexscripts/bidi/ src/java/org/apache/fop/afp/util/ src/java/org/apache/fop/complexscripts/bidi/ src/java/org/apache/fop/complexscripts/fonts/ s

[Luis Bernardo <lm...@gmail.com>]

I agree. That is the way it is done in the Apache (httpd) and OpenSSL
souce code, where it is common to see the original authors. But then,
there is no Javadoc there...

On Tue, Mar 6, 2012 at 9:37 AM, Vincent Hennebert <vh...@gmail.com> wrote:
>> + *
>> + * <p>This work was originally authored by Glenn Adams (gadams@apache.org).</p>
>>   */
>
> I think I would have preferred this to be in a non-Javadoc comment after
> the license header, as I don’t think this kind of information is
> relevant in a Javadoc, but again it doesn’t matter too much.
>
> <snip/>
>
> Vincent

Re: svn commit: r1297284 [1/2] - in /xmlgraphics/fop/trunk: ./ src/codegen/unicode/java/org/apache/fop/complexscripts/bidi/ src/java/org/apache/fop/afp/util/ src/java/org/apache/fop/complexscripts/bidi/ src/java/org/apache/fop/complexscripts/fonts/ s

[Glenn Adams <gl...@skynav.com>]

On Tue, Mar 6, 2012 at 10:55 AM, Glenn Adams <gl...@skynav.com> wrote:

> The ASF board policy [1] which I cited in the update conventions page
> (that doesn't seem to have been rsynced yet) does not call out javadoc


i just svn updated /www/xmlgraphics.apache.org/fop on people.apache.org, so
it should be rsynced shortly; i gotta remember to do that after running ant
-f publish.xml...

Re: svn commit: r1297284 [1/2] - in /xmlgraphics/fop/trunk: ./ src/codegen/unicode/java/org/apache/fop/complexscripts/bidi/ src/java/org/apache/fop/afp/util/ src/java/org/apache/fop/complexscripts/bidi/ src/java/org/apache/fop/complexscripts/fonts/ s

[Glenn Adams <gl...@skynav.com>]

The ASF board policy [1] which I cited in the update conventions page (that
doesn't seem to have been rsynced yet) does not call out javadoc, but
merely indicates that attribution of original file author, if present,
should follow the copyright and license comments.

[1]
http://mail-archives.apache.org/mod_mbox/jakarta-jmeter-dev/200402.mbox/%3C4039F65E.7020406@atg.com%3E

In making the fix to remove @author, I didn't want to move the comments
away from their original location; however, I see now that some would have
preferred they not appear in the javadocs, which I did not consider at the
time. I would not object to further changes that move them out of the
javadoc comments, but I doubt I'll have time to make another pass on this
any time soon.

On Tue, Mar 6, 2012 at 2:58 AM, Luis Bernardo <lm...@gmail.com>wrote:

> I agree. That is the way it is done in the Apache (httpd) and OpenSSL
> souce code, where it is common to see the original authors. But then,
> there is no Javadoc there...
>
> On Tue, Mar 6, 2012 at 9:37 AM, Vincent Hennebert <vh...@gmail.com>
> wrote:
> >> + *
> >> + * <p>This work was originally authored by Glenn Adams (
> gadams@apache.org).</p>
> >>   */
> >
> > I think I would have preferred this to be in a non-Javadoc comment after
> > the license header, as I don’t think this kind of information is
> > relevant in a Javadoc, but again it doesn’t matter too much.
> >
> > <snip/>
> >
> > Vincent
>