RemoteManagerHandler bugs

[Carlos Cortés del Valle <cc...@redauto.com>]

Hi,

I checked yesterday the patch for RemoteManagerHandler class because I've
been finding some bugs in this class.

>If you write a command without parameters, James's answer is command help
>(sintaxis). However, with the following commands it doesn't works:
"deluser",
>"setalias", "setforwarding" and "verify". While the first three return a
blank
>line and with a new return help is displayed, "verify" closes the
connection.

I applied deluser patch code (returning and writting in the end of function,
using a StringBuffer to store the answer) for all the commands, adding to
"verify" the null possibility in "if" condition, and they work.

I sent yesterday a bug about "setpassword" too. This function works applying
the same patch. :)

Best regards,
Carlos

PD
The attachments are the original class and the modified.


---
La ausencia de virus en el correo se comprob� al enviarlo.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.481 / Virus Database: 277 - Release Date: 13/05/2003

RE: RemoteManagerHandler bugs

["Noel J. Bergman" <no...@devtech.com>]

Carlos,

> However, in doVERIFY, the initial condition must check the argument is not
> null

Yes.  I had read over your e-mails to see if I'd missed anything, and caught
that, too.  It wasn't in what I sent you, but it is in the code committed to
the CVS.

See:
http://cvs.apache.org/viewcvs/jakarta-james/src/java/org/apache/james/remote
manager/RemoteManagerHandler.java

Thanks very much.

	--- Noel


---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org

Re: RemoteManagerHandler bugs

[Carlos Cortés del Valle <cc...@redauto.com>]

Hi Noel,

Sorry for sending the code in a bad way.

I've reviewed the new code for RemoteManageHandler you passed. After sending
you the code I generated, I focused the problem in the out.flush() action,
which wasn't in all the conditions (when a user to be deleted doesn't exist,
for example). Adding this line before every "return true", problem is fixed
(WriteLoggedFlushedResponse does the flush, so it's ok).

However, in doVERIFY, the initial condition must check the argument is not
null, because the "user.equals("")" causes an uncatching exception in this
case, and telnet connection is closed.

Regards,
Carlos



---------------------------------------------------------------------
To unsubscribe, e-mail: james-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: james-dev-help@jakarta.apache.org

RE: RemoteManagerHandler bugs

["Noel J. Bergman" <no...@devtech.com>]

Please see http://james.apache.org/contribute.html, which explains how to
submit patches.  You submitted your changes based upon revision 1.21 of the
file, which is from last November.  The current HEAD version is 1.29, and
the version 2 branch is 1.21.4.3.

> I applied deluser patch code (returning and writting in the end of
function

Actually, I didn't notice until I was looking at your changes that the
change to doDELUSER was not quite right.  It logs the usage message, which
is wrong.  We only want to log the effect of the operation.

Please review the attached, since you have been looking at the problems, and
let me know if this fixes all the problems (and doesn't introduce any new
ones).

	--- Noel

attachments:

   RemoteManagerHandler.java  - replacement file
   RemoteManager-patch.txt    - diff -u against the CVS