[GitHub] [flink] gaoyunhaii edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.

[GitBox <gi...@apache.org>]

gaoyunhaii edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-681625841


   From the failed tests, the current implementation has some problems in that the `StreamGraph` is using `AppClassLoader`, which could not load the classes in the users' code. Besides, in Client side the ThreadContextLoader is not set with the `userClassLoader` currently, therefore it would be not easy to fix this problem with the current implementation.
   
   There would be two possible solutions now:
   
   1. In the client side we also set the userClassLoader as the Thread Context ClassLoader, but I'm not very sure if it is right to do so, and it seems to involves a lot. 
   2. As an alternative, we might postpone the `clone` till when we are going to create a `RecordWriter` at the `TaskManager` side.
   
   I would first try the second method to see if the current issue could be solved separately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org