Re: svn commit: r602834 - in /incubator/sling/trunk/scripting/javascript/src: main/java/org/apache/sling/scripting/javascript/EspReader.java test/java/org/apache/sling/scripting/javascript/EspReaderTest.java

[Bertrand Delacretaz <bd...@apache.org>]

On Dec 10, 2007 10:49 AM, Felix Meschberger <Fe...@day.com> wrote:

> Am Montag, den 10.12.2007, 09:36 +0000 schrieb bdelacretaz@apache.org:
> > ...SLING-114 - output an newline after each out.write(...); to make it easier to post-process generated javascript code
>
> While it definitely makes the generated JavaScript more human-readable
> (though it really is transient), it introduces a line shift with the
> effect that an error message of Rhino will not match the input ESP line
> thus making error fixing almost impossible. ...

Ouch..sorry about that, I wasn't aware of the line numbering issue.

I'll revert the change, and then make this "always output and
end-line" feature optional, and use it only for ECT templates where
the whole generated script is visible in the browser, so line number
shifts do not matter.

-Bertrand