svn commit: r700382 - in /geronimo/gshell/trunk: gshell-assembly/src/main/underlay/etc/application.xml gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/BeanContainerContext.java

[jd...@apache.org]

Author: jdillon
Date: Tue Sep 30 01:11:38 2008
New Revision: 700382

URL: http://svn.apache.org/viewvc?rev=700382&view=rev
Log:
Notes

Modified:
    geronimo/gshell/trunk/gshell-assembly/src/main/underlay/etc/application.xml
    geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/BeanContainerContext.java

Modified: geronimo/gshell/trunk/gshell-assembly/src/main/underlay/etc/application.xml
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-assembly/src/main/underlay/etc/application.xml?rev=700382&r1=700381&r2=700382&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-assembly/src/main/underlay/etc/application.xml (original)
+++ geronimo/gshell/trunk/gshell-assembly/src/main/underlay/etc/application.xml Tue Sep 30 01:11:38 2008
@@ -22,6 +22,12 @@
 
 <application>
 
+    <!--
+    TODO: Consider making application.xml a spring beans file, with a custom 'application' (and 'settings' for settings.xml) namespace.
+          Will need a way to install application specific beans and config which is not in a plugin anyways.
+          And, we can drop the need for XStream and some of the bits from gshell-model
+    -->
+
     <groupId>org.apache.geronimo.gshell</groupId>
     <artifactId>gshell</artifactId>
     <name>GShell</name>

Modified: geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/BeanContainerContext.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/BeanContainerContext.java?rev=700382&r1=700381&r2=700382&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/BeanContainerContext.java (original)
+++ geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/BeanContainerContext.java Tue Sep 30 01:11:38 2008
@@ -48,6 +48,10 @@
 public class BeanContainerContext
     extends GenericApplicationContext
 {
+    //
+    // FIXME: Just use a BeanFactory (ConfigurableListableBeanFactory or something) as we don't need the applicationContext muck, and it eats up 500k
+    //
+
     private static final String[] CONFIG_LOCATIONS = {
         "classpath*:META-INF/spring/components.xml"
     };
@@ -56,6 +60,10 @@
 
     private final Set<Resource> ownedResources = new HashSet<Resource>();
 
+    //
+    // TODO: Implement a custom scope which can handle some of the state issues for objects that should be created once and only once for each shell instance.
+    //
+
     public BeanContainerContext(final ClassLoader classLoader) {
         this(classLoader, null);
     }