You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Matt <mi...@gmail.com> on 2016/04/10 22:37:22 UTC
Review Request 45990: Assign Slaves and Clients Page: Incorrect
validation error shown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45990/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Mahadev Konar.
Bugs: AMBARI-15783
https://issues.apache.org/jira/browse/AMBARI-15783
Repository: ambari
Description
-------
A component with cardinality "ALL" should be recommended on all hosts by component recommendation API irrespective of the data posted with the API.
Diffs
-----
ambari-server/src/main/resources/stacks/stack_advisor.py 636de01
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c577538
Diff: https://reviews.apache.org/r/45990/diff/
Testing
-------
Passed unit tests.
Deploying a cluster to test manually... Will update with results soon...
Thanks,
Matt
Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect
validation error shown
Posted by Matt <mi...@gmail.com>.
> On April 11, 2016, 1:32 p.m., Mahadev Konar wrote:
> > Matt - any update on the testing?
I just deployed the new build with my code. The issue has been fixed. I was just about to update the review.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45990/#review128242
-----------------------------------------------------------
On April 10, 2016, 1:37 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45990/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 1:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Mahadev Konar.
>
>
> Bugs: AMBARI-15783
> https://issues.apache.org/jira/browse/AMBARI-15783
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A component with cardinality "ALL" should be recommended on all hosts by component recommendation API irrespective of the data posted with the API.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/stack_advisor.py 636de01
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c577538
>
> Diff: https://reviews.apache.org/r/45990/diff/
>
>
> Testing
> -------
>
> Passed unit tests.
> Deploying a cluster to test manually... Will update with results soon...
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect
validation error shown
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45990/#review128242
-----------------------------------------------------------
Matt - any update on the testing?
- Mahadev Konar
On April 10, 2016, 8:37 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45990/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 8:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Mahadev Konar.
>
>
> Bugs: AMBARI-15783
> https://issues.apache.org/jira/browse/AMBARI-15783
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A component with cardinality "ALL" should be recommended on all hosts by component recommendation API irrespective of the data posted with the API.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/stack_advisor.py 636de01
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c577538
>
> Diff: https://reviews.apache.org/r/45990/diff/
>
>
> Testing
> -------
>
> Passed unit tests.
> Deploying a cluster to test manually... Will update with results soon...
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect
validation error shown
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45990/#review128195
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On April 10, 2016, 8:37 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45990/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 8:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Mahadev Konar.
>
>
> Bugs: AMBARI-15783
> https://issues.apache.org/jira/browse/AMBARI-15783
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A component with cardinality "ALL" should be recommended on all hosts by component recommendation API irrespective of the data posted with the API.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/stack_advisor.py 636de01
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c577538
>
> Diff: https://reviews.apache.org/r/45990/diff/
>
>
> Testing
> -------
>
> Passed unit tests.
> Deploying a cluster to test manually... Will update with results soon...
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect
validation error shown
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45990/#review128297
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On April 11, 2016, 9:17 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45990/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 9:17 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Mahadev Konar.
>
>
> Bugs: AMBARI-15783
> https://issues.apache.org/jira/browse/AMBARI-15783
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A component with cardinality "ALL" should be recommended on all hosts by component recommendation API irrespective of the data posted with the API.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/stack_advisor.py 636de01
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c577538
>
> Diff: https://reviews.apache.org/r/45990/diff/
>
>
> Testing
> -------
>
> Passed unit tests.
> Deploying a cluster for manual testing.
>
> There is no validation error regarding METRICS MONITOR after following the **steps to reproduce** as mentioned on the JIRA.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 45990: Assign Slaves and Clients Page: Incorrect
validation error shown
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45990/
-----------------------------------------------------------
(Updated April 11, 2016, 2:17 p.m.)
Review request for Ambari, Jaimin Jetly and Mahadev Konar.
Changes
-------
Testing complete.
Bugs: AMBARI-15783
https://issues.apache.org/jira/browse/AMBARI-15783
Repository: ambari
Description
-------
A component with cardinality "ALL" should be recommended on all hosts by component recommendation API irrespective of the data posted with the API.
Diffs
-----
ambari-server/src/main/resources/stacks/stack_advisor.py 636de01
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py c577538
Diff: https://reviews.apache.org/r/45990/diff/
Testing (updated)
-------
Passed unit tests.
Deploying a cluster for manual testing.
There is no validation error regarding METRICS MONITOR after following the **steps to reproduce** as mentioned on the JIRA.
Thanks,
Matt