You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (Created) (JIRA)" <ji...@apache.org> on 2011/12/21 17:01:31 UTC
[jira] [Created] (SLING-2340) jsp:forward no longer works after
SLING-2094
jsp:forward no longer works after SLING-2094
--------------------------------------------
Key: SLING-2340
URL: https://issues.apache.org/jira/browse/SLING-2340
Project: Sling
Issue Type: Improvement
Components: Scripting
Affects Versions: Scripting JSP 2.0.18
Reporter: Justin Edelson
Priority: Critical
The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174194#comment-13174194 ]
Carsten Ziegeler commented on SLING-2340:
-----------------------------------------
If I see it correctly your patch will break SLING-2094 again.
Now I see the problem, forward() is used in two cases: the real forward and for error handling
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174216#comment-13174216 ]
Justin Edelson commented on SLING-2340:
---------------------------------------
We don't a test for jsp:forward. I have one locally (now). We supposedly have tests of SLING-2094 and this patch does not seem to break those.
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174243#comment-13174243 ]
Justin Edelson commented on SLING-2340:
---------------------------------------
third patch: http://codereview.appspot.com/5500063
this one adds a new test and doesn't break the SLING-2094 test. WDYT?
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174176#comment-13174176 ]
Carsten Ziegeler commented on SLING-2340:
-----------------------------------------
But the above code is just executed in the exception case, or am I missing something?
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174233#comment-13174233 ]
Justin Edelson commented on SLING-2340:
---------------------------------------
I take it back... I was testing the wrong thing. This patch does break the SLING-2094 test.
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174196#comment-13174196 ]
Carsten Ziegeler commented on SLING-2340:
-----------------------------------------
Do we have some samples for forward?
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174453#comment-13174453 ]
Justin Edelson commented on SLING-2340:
---------------------------------------
fixed in r1221900
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Critical
> Fix For: Scripting JSP 2.0.20
>
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Bertrand Delacretaz (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174201#comment-13174201 ]
Bertrand Delacretaz commented on SLING-2340:
--------------------------------------------
> Do we have some samples for forward?
or tests? ;-)
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174269#comment-13174269 ]
Carsten Ziegeler commented on SLING-2340:
-----------------------------------------
Looks good to me
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-2340.
-----------------------------------
Resolution: Fixed
Fix Version/s: Scripting JSP 2.0.20
Assignee: Justin Edelson
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Critical
> Fix For: Scripting JSP 2.0.20
>
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174177#comment-13174177 ]
Justin Edelson commented on SLING-2340:
---------------------------------------
proposed patch here: http://codereview.appspot.com/5501055
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Carsten Ziegeler (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-2340.
-----------------------------------
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Assignee: Justin Edelson
> Priority: Critical
> Fix For: Scripting JSP 2.0.20
>
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2340) jsp:forward no longer works after
SLING-2094
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174221#comment-13174221 ]
Justin Edelson commented on SLING-2340:
---------------------------------------
patch with jsp:forward test here: http://codereview.appspot.com/5500062
> jsp:forward no longer works after SLING-2094
> --------------------------------------------
>
> Key: SLING-2340
> URL: https://issues.apache.org/jira/browse/SLING-2340
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JSP 2.0.18
> Reporter: Justin Edelson
> Priority: Critical
>
> The changes made for SLING-2094 seem to have completely broken support for jsp:forward. Whereas the foward method in PageContextImpl() used to do a forward, now it just throws an exception:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp/src/main/java/org/apache/sling/scripting/jsp/jasper/runtime/PageContextImpl.java?r1=1096843&r2=1145904
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira