You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Daniel del Castillo <da...@hotmail.com> on 2015/10/30 12:53:29 UTC

Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1573
    https://issues.apache.org/jira/browse/FALCON-1573


Repository: falcon-git


Description
-------

Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.


Diffs
-----

  oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 09c29abccfa298e3ef02f2bd4250f4ed17bf2cbc 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
  oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 

Diff: https://reviews.apache.org/r/39812/diff/


Testing
-------

UT added.
Manual functional testing done.


Thanks,

Daniel del Castillo


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review106555
-----------------------------------------------------------

Ship it!


Ship It!


docs/src/site/twiki/restapi/EntitySchedule.twiki (line 22)
<https://reviews.apache.org/r/39812/#comment165258>

    This is delightful documentation. Thank you for documenting it so well.


- Ajay Yadava


On Nov. 5, 2015, 2:24 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:24 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Daniel del Castillo <da...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/
-----------------------------------------------------------

(Updated Nov. 5, 2015, 2:24 p.m.)


Review request for Falcon.


Changes
-------

Example added


Bugs: FALCON-1573
    https://issues.apache.org/jira/browse/FALCON-1573


Repository: falcon-git


Description
-------

Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.


Diffs (updated)
-----

  CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
  docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
  docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
  oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
  oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 

Diff: https://reviews.apache.org/r/39812/diff/


Testing
-------

UT added.
Manual functional testing done.


Thanks,

Daniel del Castillo


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Daniel del Castillo <da...@hotmail.com>.

> On Nov. 4, 2015, 5:36 p.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 47
> > <https://reviews.apache.org/r/39812/diff/2/?file=1115698#file1115698line47>
> >
> >     Hmm...seems like earlier property "falcon.scheduler" is also not documented. Our existing documentation is not actually a good example, but I hope you will do better than us :)

Since I'm updating this file I don't mind to document this property as well although I think this should go in a more comprenhensive page rather than here


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review105084
-----------------------------------------------------------


On Nov. 5, 2015, 2:24 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:24 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Ajay Yadava <aj...@gmail.com>.

> On Nov. 4, 2015, 5:36 p.m., Ajay Yadava wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 47
> > <https://reviews.apache.org/r/39812/diff/2/?file=1115698#file1115698line47>
> >
> >     Hmm...seems like earlier property "falcon.scheduler" is also not documented. Our existing documentation is not actually a good example, but I hope you will do better than us :)
> 
> Daniel del Castillo wrote:
>     Since I'm updating this file I don't mind to document this property as well although I think this should go in a more comprenhensive page rather than here

Yes, you are right. I will create a JIRA for the same.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review105084
-----------------------------------------------------------


On Nov. 5, 2015, 2:24 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 2:24 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review105084
-----------------------------------------------------------



docs/src/site/twiki/FalconCLI.twiki (line 47)
<https://reviews.apache.org/r/39812/#comment163471>

    Hmm...seems like earlier property "falcon.scheduler" is also not documented. Our existing documentation is not actually a good example, but I hope you will do better than us :)



docs/src/site/twiki/FalconCLI.twiki (line 48)
<https://reviews.apache.org/r/39812/#comment163469>

    It will be really useful to add an example here as well, just like you have added in JIRA.


- Ajay Yadava


On Nov. 4, 2015, 4:35 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 4:35 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Daniel del Castillo <da...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/
-----------------------------------------------------------

(Updated Nov. 4, 2015, 4:35 p.m.)


Review request for Falcon.


Changes
-------

Branch removed


Bugs: FALCON-1573
    https://issues.apache.org/jira/browse/FALCON-1573


Repository: falcon-git


Description
-------

Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.


Diffs
-----

  CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
  docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
  docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
  oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
  oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 

Diff: https://reviews.apache.org/r/39812/diff/


Testing
-------

UT added.
Manual functional testing done.


Thanks,

Daniel del Castillo


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Daniel del Castillo <da...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/
-----------------------------------------------------------

(Updated Nov. 4, 2015, 3:38 p.m.)


Review request for Falcon.


Changes
-------

I've added some comments to the doc and removed values in the log trace


Bugs: FALCON-1573
    https://issues.apache.org/jira/browse/FALCON-1573


Repository: falcon-git


Description
-------

Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.


Diffs (updated)
-----

  CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
  docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
  docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
  oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
  oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
  oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 

Diff: https://reviews.apache.org/r/39812/diff/


Testing
-------

UT added.
Manual functional testing done.


Thanks,

Daniel del Castillo


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Ajay Yadava <aj...@gmail.com>.

> On Nov. 3, 2015, 1:53 p.m., Ajay Yadava wrote:
> > This is a very useful feature and it will be really helpful to document these options in schedule api with an example.
> 
> Daniel del Castillo wrote:
>     Hi Ajay, I'd like to add an example showing the entity XML and how to reference the properties passed on schedule (kind of similar to what's in Jira) but I'm not sure if EntitySchedule.twiki is the best place for this. Can you advise please?

Hi Daniel,

EntitySchedule.twiki is actually the right place to document it with example.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review104910
-----------------------------------------------------------


On Nov. 4, 2015, 4:35 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 4:35 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Daniel del Castillo <da...@hotmail.com>.

> On Nov. 3, 2015, 1:53 p.m., Ajay Yadava wrote:
> > This is a very useful feature and it will be really helpful to document these options in schedule api with an example.

Hi Ajay, I'd like to add an example showing the entity XML and how to reference the properties passed on schedule (kind of similar to what's in Jira) but I'm not sure if EntitySchedule.twiki is the best place for this. Can you advise please?


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review104910
-----------------------------------------------------------


On Nov. 4, 2015, 3:38 p.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 3:38 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt ebb22cd97e0e89c14bbc11e6a76bae1fb25a808e 
>   docs/src/site/twiki/FalconCLI.twiki e001a7f34977a4d84c5f45d5517dfbfb898d862d 
>   docs/src/site/twiki/restapi/EntitySchedule.twiki 263d1523c20c3f7b78d4ae2b1cba2eb4904977f2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7262964c17ec9465099066e359772580792d06a3 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>


Re: Review Request 39812: FACLON-1573 - Supply user-defined properties to Oozie workflows during schedule

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39812/#review104910
-----------------------------------------------------------


This is a very useful feature and it will be really helpful to document these options in schedule api with an example.

- Ajay Yadava


On Oct. 30, 2015, 11:53 a.m., Daniel del Castillo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39812/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 11:53 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1573
>     https://issues.apache.org/jira/browse/FALCON-1573
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Make user-defined properties passed in the entity sechdule service available in the configuration of the coordinator job so they can be used in the workflow. Please see Jira ticket for further details.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java e0af30deb355b58ad8edab5b1fd7129944838ac8 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 09c29abccfa298e3ef02f2bd4250f4ed17bf2cbc 
>   oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java 5e930272864aebe44cae0eea2eb85977fbeeb6cf 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 9f492d7b22001dd016e5d2ca12909d84d3a0c5f4 
> 
> Diff: https://reviews.apache.org/r/39812/diff/
> 
> 
> Testing
> -------
> 
> UT added.
> Manual functional testing done.
> 
> 
> Thanks,
> 
> Daniel del Castillo
> 
>