You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/29 16:03:00 UTC
[GitHub] [spark] allisonwang-db opened a new pull request, #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
allisonwang-db opened a new pull request, #38050:
URL: https://github.com/apache/spark/pull/38050
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR checks unsupported data types when decorrelating subqueries, and throws a more user-friendly error message if so.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There are certain data types (e.g MapType) that do not support ordering. This will cause the join conditions added by `DecorrelateInnerQuery` unresolved. We want to improve the error messages in this case.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. This PR introduces a new error message.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on PR #38050:
URL: https://github.com/apache/spark/pull/38050#issuecomment-1265541017
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r990410758
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -879,6 +879,11 @@
"Expressions referencing the outer query are not supported outside of WHERE/HAVING clauses<treeNode>"
]
},
+ "UNSUPPORTED_CORRELATED_REFERENCE_DATA_TYPE" : {
+ "message" : [
+ "Correlated column reference '<expr>' cannot be <dataType> type"
Review Comment:
+1 this is better!
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -369,7 +370,7 @@ object DecorrelateInnerQuery extends PredicateHelper {
throw QueryCompilationErrors.unsupportedCorrelatedReferenceDataTypeError(
o, a.dataType, plan.origin)
} else {
- throw new IllegalStateException(s"Unable to decorrelate subquery: " +
+ throw SparkException.internalError(s"Unable to decorrelate subquery: " +
Review Comment:
Why this change?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -3138,4 +3138,4 @@
"<className> must override either <m1> or <m2>"
]
}
-}
+}
Review Comment:
Bit revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r990171074
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -360,7 +360,20 @@ object DecorrelateInnerQuery extends PredicateHelper {
// +- Aggregate [a1] [a1 AS a']
// +- OuterQuery
val conditions = outerReferenceMap.map {
- case (o, a) => EqualNullSafe(a, OuterReference(o))
+ case (o, a) =>
+ val cond = EqualNullSafe(a, OuterReference(o))
+ // SPARK-40615: Certain data types (e.g. MapType) do not support ordering, so
+ // the EqualNullSafe join condition can become unresolved.
+ if (!cond.resolved) {
+ if (!RowOrdering.isOrderable(a.dataType)) {
+ throw QueryCompilationErrors.unsupportedCorrelatedReferenceDataTypeError(
+ o, a.dataType, plan.origin)
+ } else {
+ throw new IllegalStateException(s"Unable to decorrelate subquery: " +
Review Comment:
if this should never happen, let's use `SparkException.internalError`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r983857444
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -888,6 +888,11 @@
"message" : [
"IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands<treeNode>"
]
+ },
+ "UNSUPPORTED_OUTER_REFERENCE_DATA_TYPE" : {
+ "message" : [
+ "Correlated column references do not support data type <dataType>: <expr>"
Review Comment:
Nit: I found it was a bit confusing to read the error message instance: `Correlated column references do not support data type map<string,int>: v1.x`.
Basically `v1.x` as an expression was not clear in the error message.
For example to me this is more clear: `Correlated column references do not support expression v1.x due to unsupported data type map<string,int>`. Something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r990447400
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -369,7 +370,7 @@ object DecorrelateInnerQuery extends PredicateHelper {
throw QueryCompilationErrors.unsupportedCorrelatedReferenceDataTypeError(
o, a.dataType, plan.origin)
} else {
- throw new IllegalStateException(s"Unable to decorrelate subquery: " +
+ throw SparkException.internalError(s"Unable to decorrelate subquery: " +
Review Comment:
See https://github.com/apache/spark/pull/38050#discussion_r990171074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
URL: https://github.com/apache/spark/pull/38050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r989213338
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -888,6 +888,11 @@
"message" : [
"IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands<treeNode>"
]
+ },
+ "UNSUPPORTED_OUTER_REFERENCE_DATA_TYPE" : {
+ "message" : [
+ "Correlated column references do not support data type <dataType>: <expr>"
Review Comment:
Thanks @amaliujia @cloud-fan I will update the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38050:
URL: https://github.com/apache/spark/pull/38050#issuecomment-1282483048
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r990410429
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -3138,4 +3138,4 @@
"<className> must override either <m1> or <m2>"
]
}
-}
+}
Review Comment:
Nit: revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r990420325
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala:
##########
@@ -369,7 +370,7 @@ object DecorrelateInnerQuery extends PredicateHelper {
throw QueryCompilationErrors.unsupportedCorrelatedReferenceDataTypeError(
o, a.dataType, plan.origin)
} else {
- throw new IllegalStateException(s"Unable to decorrelate subquery: " +
+ throw SparkException.internalError(s"Unable to decorrelate subquery: " +
Review Comment:
oh I saw Wenchen's comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38050:
URL: https://github.com/apache/spark/pull/38050#issuecomment-1271995077
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38050: [SPARK-40615][SQL] Check unsupported data types when decorrelating subqueries
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38050:
URL: https://github.com/apache/spark/pull/38050#discussion_r983862361
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -888,6 +888,11 @@
"message" : [
"IN/EXISTS predicate subqueries can only be used in filters, joins, aggregations, window functions, projections, and UPDATE/MERGE/DELETE commands<treeNode>"
]
+ },
+ "UNSUPPORTED_OUTER_REFERENCE_DATA_TYPE" : {
+ "message" : [
+ "Correlated column references do not support data type <dataType>: <expr>"
Review Comment:
Maybe even `Correlated column references do not support data type map<string,int> of expression v1.x` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org