You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "wrongtest-intellif (via GitHub)" <gi...@apache.org> on 2023/05/17 04:11:43 UTC

[GitHub] [tvm] wrongtest-intellif opened a new pull request, #14866: [TIR] Avoid too complex predicate in compaction

wrongtest-intellif opened a new pull request, #14866:
URL: https://github.com/apache/tvm/pull/14866

   Revert the behavior to add pending predicates not fully solved via linear solver. They are too complex to get easily handled when we estimate the predicated the buffer region. Refer to https://github.com/apache/tvm/issues/14834
   
   Eg, if the linear solver handle 
   
   `i_j_fused_0 * 65536 + i_j_fused_1 * 256 + i_j_fused_2 < n * n` 
   
   failed, it would give out "unresolved" relations:
   
   `i_j_fused_0 * 65536 + 65536 <= (n * n + 65535) // 65536 * 65536 and i_j_fused_0 * 65536 < n * n - i_j_fused_2 - i_j_fused_1 * 256 and i_j_fused_1 * 256 < n * n - i_j_fused_2 and i_j_fused_2 < n * n and 1 <= n * n`
   
   It seeems not a good idea to add them. Instead, we preserve the origin one as before #14021.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #14866: [TIR] Avoid too complex predicate in compaction

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #14866:
URL: https://github.com/apache/tvm/pull/14866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14866: [TIR] Avoid too complex predicate in compaction

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14866:
URL: https://github.com/apache/tvm/pull/14866#issuecomment-1550673339

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #14866: [TIR] Avoid too complex predicate in compaction

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #14866:
URL: https://github.com/apache/tvm/pull/14866#issuecomment-1551475409

   cc @MasterJH5574 @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org