You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "papegaaij (via GitHub)" <gi...@apache.org> on 2024/02/25 20:09:54 UTC
[PR] Fix condition for simple top level navigation [wicket]
papegaaij opened a new pull request, #798:
URL: https://github.com/apache/wicket/pull/798
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix condition for simple top level navigation [wicket]
Posted by "papegaaij (via GitHub)" <gi...@apache.org>.
papegaaij merged PR #798:
URL: https://github.com/apache/wicket/pull/798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix condition for simple top level navigation [wicket]
Posted by "papegaaij (via GitHub)" <gi...@apache.org>.
papegaaij commented on PR #798:
URL: https://github.com/apache/wicket/pull/798#issuecomment-1963700023
@martin-g The tests were already supposed to check this behavior, however WicketTester defaults to POST, which caused it not to trigger the error. I've updated the tests to use GET. Also, the test that was supposed to check the top level navigation did not trigger that specific code, because it used an incorrect sec-fetch-site header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix condition for simple top level navigation [wicket]
Posted by "papegaaij (via GitHub)" <gi...@apache.org>.
papegaaij commented on PR #798:
URL: https://github.com/apache/wicket/pull/798#issuecomment-1963755339
> Maybe we should add a new test for POST too ?
Yes, good idea. I've added the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix condition for simple top level navigation [wicket]
Posted by "papegaaij (via GitHub)" <gi...@apache.org>.
papegaaij commented on PR #798:
URL: https://github.com/apache/wicket/pull/798#issuecomment-1963617953
Good point. I'll take a look at the tests we currently have for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org