You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2025/10/08 14:50:42 UTC

[PR] Fix #11199: Maven 4.0.0-rc-4 ignores defaultLogLevel [maven]

gnodet opened a new pull request, #11219:
URL: https://github.com/apache/maven/pull/11219

   The issue was that LookupInvoker always called setRootLoggerLevel() with INFO level even when no CLI options were specified, overriding configuration file settings by setting a system property.
   
   Changes:
   - LookupInvoker.prepareLogging(): Only call setRootLoggerLevel() when CLI options (-X, -q) are explicitly specified, allowing config file to work
   - MavenSimpleConfiguration: Improved switch statement clarity
   - Added comprehensive unit tests for both logging configuration and CLI behavior
   
   This ensures that maven.logger.defaultLogLevel=off in configuration files is properly respected when no CLI logging options are provided, while maintaining backward compatibility with CLI option overrides.
   
   Fixes #11199
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
   - [ ] Your pull request should address just one issue, without pulling in other changes.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
     Note that commits might be squashed by a maintainer on merge.
   - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
     This may not always be possible but is a best-practice.
   - [ ] Run `mvn verify` to make sure basic checks pass.
     A more thorough check will be performed on your pull request automatically.
   - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #11199: Maven 4.0.0-rc-4 ignores defaultLogLevel [maven]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #11219:
URL: https://github.com/apache/maven/pull/11219#issuecomment-6216715792

   <!-- maven-backport-bot -->
   
   **Conflicts — manual resolution needed:**
   - ❌ `maven-4.0.x`: Cherry-pick conflict in: impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/LookupInvokerLoggingTest.java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #11199: Maven 4.0.0-rc-4 ignores defaultLogLevel [maven]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #11219:
URL: https://github.com/apache/maven/pull/11219#issuecomment-3383260206

   ## 💚 All backports created successfully
   
   | Status | Branch | Result |
   |:------:|:------:|:------|
   |✅|maven-4.0.x|[<img src="https://img.shields.io/github/pulls/detail/state/apache/maven/11227">](https://github.com/apache/maven/pull/11227)|
   
   ### Questions ?
   Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)
   
   <!--- Backport version: 10.0.1 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #11199: Maven 4.0.0-rc-4 ignores defaultLogLevel [maven]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #11219:
URL: https://github.com/apache/maven/pull/11219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org