You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/27 07:17:12 UTC

[GitHub] [geode] mkevo commented on a change in pull request #5669: GEODE-8655: handling exception on SNIHostName

mkevo commented on a change in pull request #5669:
URL: https://github.com/apache/geode/pull/5669#discussion_r512460417



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -846,7 +846,14 @@ private boolean setServerNames(SSLParameters modifiedParams, HostAndPort addr) {
         // ignore - we'll see what happens with endpoint validation using a numeric address...
       }
     }
-    serverNames.add(new SNIHostName(hostName));
+    try {
+      serverNames.add(new SNIHostName(hostName));
+    } catch (Exception ex) {

Review comment:
       Hi @bschuchardt ,
   What do you mean by throwing an informative exception?
   Is it ok to log it in warn level?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org