You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2021/02/16 17:19:12 UTC
[tika] branch branch_1x updated: improve lyrics handling
This is an automated email from the ASF dual-hosted git repository.
tallison pushed a commit to branch branch_1x
in repository https://gitbox.apache.org/repos/asf/tika.git
The following commit(s) were added to refs/heads/branch_1x by this push:
new 26a9965 improve lyrics handling
26a9965 is described below
commit 26a9965659921a8aa4205393479584372db7cb35
Author: tballison <ta...@apache.org>
AuthorDate: Tue Feb 16 12:19:00 2021 -0500
improve lyrics handling
---
.../src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tika-parsers/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java b/tika-parsers/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java
index 12d0f2d..06a234b 100644
--- a/tika-parsers/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java
+++ b/tika-parsers/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java
@@ -100,9 +100,12 @@ public class LyricsHandler {
int tagLen = Integer.parseInt(
lyrics.substring(pos+3, pos+8)
);
+ if (tagLen < 1 || tagLen > lyrics.length()) {
+ //something went wrong
+ break;
+ }
int startPos = pos + 8;
int endPos = startPos + tagLen;
-
if(tagName.equals("LYR")) {
lyricsText = lyrics.substring(startPos, endPos);
}