[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #5005: feat: add finished_date to cicd_deployment_commits table

["abeizn (via GitHub)" <gi...@apache.org>]

abeizn commented on code in PR #5005:
URL: https://github.com/apache/incubator-devlake/pull/5005#discussion_r1174520438


##########
backend/plugins/dora/tasks/deployment_commits_generator.go:
##########
@@ -123,6 +123,7 @@ func GenerateDeploymentCommits(taskCtx plugin.SubTaskContext) errors.Error {
 				RepoId:         pipelineCommit.RepoId,
 				RepoUrl:        pipelineCommit.RepoUrl,
 			}
+			domainDeployCommit.FinishedDate = pipelineCommit.FinishedDate

Review Comment:
   Is this line in the right place?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org