You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2021/02/16 07:20:17 UTC
Re: Review Request 73182: ATLAS-4139 [Atlas: Glossary Term Bulk
Import] When AdditionalAttributes is not provided in key:value format,
the error message does not convey that.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73182/
-----------------------------------------------------------
(Updated Feb. 16, 2021, 7:20 a.m.)
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
ATLAS-4135 [Atlas: Glossary Term Bulk Import] It will be good to ignore the glossaries and terms that are already present instead of failing the bulk import
Summary (updated)
-----------------
ATLAS-4139 [Atlas: Glossary Term Bulk Import] When AdditionalAttributes is not provided in key:value format, the error message does not convey that.
Bugs: ATLAS-4135 and ATLAS-4139
https://issues.apache.org/jira/browse/ATLAS-4135
https://issues.apache.org/jira/browse/ATLAS-4139
Repository: atlas
Description (updated)
-------
This patch changes the error message
This patch ignore the glossaries and terms that are already present instead of failing the bulk import
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 82243e2
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 2c84ec7
Diff: https://reviews.apache.org/r/73182/diff/2/
Changes: https://reviews.apache.org/r/73182/diff/1-2/
Testing
-------
Basic Testing is done
Thanks,
Mandar Ambawane
Re: Review Request 73182: ATLAS-4139 [Atlas: Glossary Term Bulk
Import] When AdditionalAttributes is not provided in key:value format,
the error message does not convey that.
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73182/#review222598
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 15, 2021, 11:20 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73182/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2021, 11:20 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4135 and ATLAS-4139
> https://issues.apache.org/jira/browse/ATLAS-4135
> https://issues.apache.org/jira/browse/ATLAS-4139
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch changes the error message
>
> This patch ignore the glossaries and terms that are already present instead of failing the bulk import
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 82243e2
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 2c84ec7
>
>
> Diff: https://reviews.apache.org/r/73182/diff/2/
>
>
> Testing
> -------
>
> Basic Testing is done
>
>
> Thanks,
>
> Mandar Ambawane
>
>