[GitHub] [lucene] javanna commented on pull request #11793: Prevent PointValues from returning null for ghost fields

[GitBox <gi...@apache.org>]

javanna commented on PR #11793:
URL: https://github.com/apache/lucene/pull/11793#issuecomment-1289134578

   @jpountz I addressed the check index issue, and pushed an update around the packed values that are null in the empty point values instance. That scenario is a bit tricky and ghost fields are not extensively tested, I wonder if more testing is a thing we'd like to do. I am not entirely sure if things may go wrong when the packed values are retrieved with `PointTree`. That should be the `intersect` path and I could not yet determine if there may be NPEs there too with ghost fields. I am though under impression that we assumed before that `PointValues` is not null, hence in the worst case we would still have an NPE but in a different place.
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org