You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/11 14:54:47 UTC
[GitHub] [flink] aljoscha commented on a change in pull request #10104:
[FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to
simplify inheritance
aljoscha commented on a change in pull request #10104: [FLINK-14629][client] Refactor ScalaShellRemote(Stream)Environment to simplify inheritance
URL: https://github.com/apache/flink/pull/10104#discussion_r344744333
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
##########
@@ -84,7 +84,7 @@ public JobExecutionResult execute(String jobName) throws Exception {
client.getFlinkConfiguration(),
getParallelism());
- ClientUtils.addJarFiles(jobGraph, this.jarFilesToAttach);
+ org.apache.flink.runtime.client.ClientUtils.addJarFiles(jobGraph, this.jarFilesToAttach);
Review comment:
I think it's problematic that we have two `ClientUtils`, maybe this should be refactored/renamed before this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services