You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/09/02 09:26:21 UTC
[GitHub] zeppelin pull request #1397: [ZEPPELIN-1406] modify to load method artifact ...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1397
[ZEPPELIN-1406] modify to load method artifact local path in Helium application json
### What is this PR for?
Currently contained in the Zeppelin Helium application does not work.
The relative value of the configuration file path does incurring call normally.
Therefore, it sets the Helium directory you specified in the application default directory.
An example of the application was to modify the path of helium.
### What type of PR is it?
Bug Fix, Improvement
### Todos
- [x] added setter method for artifact in Helium Packakge class
- [x] if not absolute path for artifact then replace to absolute path for helium artifact local path
- [x] replace helium example artifact path for json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1406
### How should this be tested?
step 1.
build
```
mvn clean package -DskipTests -Pbuild-distr -Pexamples -DskipTests
```
step 2.
go to web ui and someone notebook.
write paragraph.
here.
```
%spark
import java.util.Date
new Date();
```
step 3.
choice.
helium application clock.
working well.
### Screenshots (if appropriate)
#### before
does not working.
#### after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin dev/helium-json-relative-path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1397.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1397
----
commit ad84e5b6f6945bc6e7209ba19d578fd7bf1c0e04
Author: CloverHearts <cl...@gmail.com>
Date: 2016-09-02T09:07:20Z
modification to artifact local path in Helium application json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1397: [ZEPPELIN-1406] modify to load method artifact local p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1397
@cloverhearts I can't reproduce this bug. Here is what I did.
###### 1. Build the latest `master` branch with below command and restart Zeppelin daemon
```
mvn clean package -Pbuild-distr -Pexamples -DskipTests
```
###### 2. Create a new notebook and run
```
%spark
import java.util.Date
new Date();
```
###### 3. I can see the Helium icon and the clock without this patch
Did I miss something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1397: [ZEPPELIN-1406] modify to load method artifact local p...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1397
@AhyoungRyu
I'll check it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1397: [ZEPPELIN-1406] modify to load method artifact ...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---