[GitHub] mistercrunch commented on issue #3437: Feature: Display the verbose name for metrics within Charts and legend.

[gi...@git.apache.org]

mistercrunch commented on issue #3437: Feature: Display the verbose name for metrics within Charts and legend.
URL: https://github.com/apache/incubator-superset/pull/3437#issuecomment-329363620
 
 
   I'm afraid that the verbose name can have funky characters that could be problematic (is unicode in dict keys ok in 2.7?) and can't provide the guarantees we need around it being unique within a datasource (column collision in dataframes), plus often we use the coalesce of verbose_name/actual_name. I think I'd rather replace it in the view as we display things.
   
   Of course the downside is having to do it in every single visualization.
   
   I'm not 100% on this but I think I'd rather go in the direction of enforcing unicity in the (non-verbose) names and not allowing funky characters in there and use those internally until the view layer.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services