[jira] [Commented] (AMBARI-3617) killstaleprocesses() in ambari_agent/shell.py does not read pid files correctly

["Dmytro Sen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-3617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811576#comment-13811576 ] 

Dmytro Sen commented on AMBARI-3617:
------------------------------------

I've just removed killstaleprocesses() from the code. Now this bug can't be reproduced. 
[~tmckay],
Could you please close this JIRA?

Thanks.

> killstaleprocesses() in ambari_agent/shell.py does not read pid files correctly
> -------------------------------------------------------------------------------
>
>                 Key: AMBARI-3617
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3617
>             Project: Ambari
>          Issue Type: Bug
>          Components: agent
>    Affects Versions: 1.4.2
>         Environment: RHEL6 agent
>            Reporter: Trevor McKay
>            Assignee: Trevor McKay
>         Attachments: AMBARI-3617.patch
>
>
> The killstaleprocesses() routine in shell.py expects pidfiles to have a pid value encoded in the name (ie the name is of the form PIDVALUE.pid).
> However, ambari-agent for example writes the file "ambari-agent.pid" with the pid contained within.
> killstaleprocesses() should handle both forms, or ignore files that are not of the form PIDVALUE.pid



--
This message was sent by Atlassian JIRA
(v6.1#6144)