You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2012/07/18 23:40:47 UTC
Review Request: Master failover allocator tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
Review request for mesos.
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs
-----
src/tests/allocator_tests.cpp b3db13d
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Master failover allocator tests
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
(Updated Aug. 15, 2012, 11:12 p.m.)
Review request for mesos.
Changes
-------
Updated to latest review.
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs (updated)
-----
src/Makefile.am b0cb6cc
src/tests/allocator_tests.cpp 98efb0d
src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
src/tests/utils.hpp caf5926
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Master failover allocator tests
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/#review10369
-----------------------------------------------------------
Ship it!
Awesome.
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/6037/#comment22032>
A comment reminding users how/why this works would be fantastic!
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/6037/#comment22033>
Let's use a sleep for now with a TODO to replace this with a Clock::advance().
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/6037/#comment22034>
Ditto above.
src/tests/allocator_zookeeper_tests.cpp
<https://reviews.apache.org/r/6037/#comment22035>
Cleanup (remove unused code and unused variable).
src/tests/utils.hpp
<https://reviews.apache.org/r/6037/#comment22040>
Wrap to 80 characters please.
src/tests/utils.hpp
<https://reviews.apache.org/r/6037/#comment22036>
'{' on new line.
src/tests/utils.hpp
<https://reviews.apache.org/r/6037/#comment22037>
Ditto.
src/tests/utils.hpp
<https://reviews.apache.org/r/6037/#comment22038>
Ditto.
src/tests/utils.hpp
<https://reviews.apache.org/r/6037/#comment22039>
Ditto.
- Benjamin Hindman
On Aug. 14, 2012, 7:44 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6037/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2012, 7:44 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
>
>
> Diffs
> -----
>
> src/Makefile.am b0cb6cc
> src/tests/allocator_tests.cpp 98efb0d
> src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
> src/tests/utils.hpp caf5926
>
> Diff: https://reviews.apache.org/r/6037/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Master failover allocator tests
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
(Updated Aug. 14, 2012, 7:44 p.m.)
Review request for mesos.
Changes
-------
Added whitelist test.
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs (updated)
-----
src/Makefile.am b0cb6cc
src/tests/allocator_tests.cpp 98efb0d
src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
src/tests/utils.hpp caf5926
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Master failover allocator tests
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
(Updated Aug. 13, 2012, 4:50 p.m.)
Review request for mesos.
Changes
-------
Updated to trunk.
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs (updated)
-----
src/Makefile.am b0cb6cc
src/tests/allocator_tests.cpp 98efb0d
src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
src/tests/utils.hpp caf5926
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Master failover allocator tests
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
(Updated Aug. 10, 2012, 8:47 p.m.)
Review request for mesos.
Changes
-------
Updated to pass with the new batch stuff. This diff still assumes you're applying to the current (non batch allocation) trunk, but I attached another file that makes the necessary changes so that you should be able to apply batch.patch, this patch, and then the attached patch and have everything work (I'll update the main diff for this review to include the changes in the attached file when the batch stuff gets committed to trunk).
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs (updated)
-----
src/Makefile.am 75f8083
src/tests/allocator_tests.cpp b3db13d
src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
src/tests/utils.hpp a768360
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Master failover allocator tests
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
(Updated Aug. 8, 2012, 12:29 a.m.)
Review request for mesos.
Changes
-------
Minor fix.
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs (updated)
-----
src/Makefile.am cc3480c
src/tests/allocator_tests.cpp b3db13d
src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
src/tests/utils.hpp a768360
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: Master failover allocator tests
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6037/
-----------------------------------------------------------
(Updated Aug. 1, 2012, 9:08 p.m.)
Review request for mesos.
Changes
-------
- Added a number of new tests around failover/restart situation.
- Made offer checking better by implementing the OfferEq matcher.
- Moved tests using zookeeper into a separate file to facilitate make check without java.
Known Issues:
- The zookeeper implementation fails to create znodes when running on Ubuntu, causing tests requiring zookeeper to fail. I'm looking into it, but the zookeeper implementation is outside the scope of what I've worked on before.
Description
-------
New tests for the bug Ben found where the order of slave/framework reregisters after a master failover was causing issues.
Diffs (updated)
-----
src/Makefile.am 10f1101
src/tests/allocator_tests.cpp b3db13d
src/tests/allocator_zookeeper_tests.cpp PRE-CREATION
src/tests/utils.hpp a768360
Diff: https://reviews.apache.org/r/6037/diff/
Testing
-------
make check
Thanks,
Thomas Marshall