[GitHub] wohali commented on issue #1435: report git sha on welcome request

[GitBox <gi...@apache.org>]

wohali commented on issue #1435: report git sha on welcome request
URL: https://github.com/apache/couchdb/pull/1435#issuecomment-404868886
 
 
   @janl No, this is still broken. `make dist` should produce a tarball at anytime that includes the git sha.
   
   Running my test case above on your branch, with no tags, I get this:
   
   ```
   $ curl localhost:15984
   {"couchdb":"Welcome","version":"2.2.0","git_sha":"","features":["pluggable-storage-engines","scheduler"],"vendor":{"name":"The Apache Software Foundation"}}
   ```
   
   The git sha should be 'baked' into the result of `make dist` regardless of whether we're on a tag or not. This allows us to distinguish actual releases from RCs from merely snapshot builds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services