You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/11/02 11:12:23 UTC

[GitHub] [couchdb-nano] insidewhy commented on a diff in pull request #311: fix typing of 'since' options

insidewhy commented on code in PR #311:
URL: https://github.com/apache/couchdb-nano/pull/311#discussion_r1011584073


##########
lib/nano.d.ts:
##########
@@ -248,7 +248,7 @@ declare namespace nano {
     /** whether to get a faster changes feed by supplying 'seq_interval'   */
     fastChanges?: boolean;
     /** where to begin the changes feed: 0, now or a sequence token */
-    since?: string;
+    since?: string | number;

Review Comment:
   `0` is accepted so added `| number`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org