You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2004/10/04 20:34:26 UTC
Re: svn commit: r11233 - trunk/subversion/clients/cmdline
On Mon, 4 Oct 2004 lundblad@tigris.org wrote:
> Author: lundblad
> Date: Mon Oct 4 15:01:33 2004
> New Revision: 11233
>
> Modified:
> trunk/subversion/clients/cmdline/cl.h
> trunk/subversion/clients/cmdline/propedit-cmd.c
> trunk/subversion/clients/cmdline/util.c
> Log:
> Fix issue #2063: handle platform eol-style in propedit. Also makes
> --encoding work for propedit.
>
This needs to be verified by someone on Win32. It should fix the eol
problem.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r11233 - trunk/subversion/clients/cmdline
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Mon, 4 Oct 2004, Philip Martin wrote:
> "Peter N. Lundblad" <pe...@famlundblad.se> writes:
>
> > On Mon, 4 Oct 2004 lundblad@tigris.org wrote:
> >
> >> Author: lundblad
> >> Date: Mon Oct 4 15:01:33 2004
> >> New Revision: 11233
> >>
> >> Modified:
> >> trunk/subversion/clients/cmdline/cl.h
> >> trunk/subversion/clients/cmdline/propedit-cmd.c
> >> trunk/subversion/clients/cmdline/util.c
> >> Log:
> >> Fix issue #2063: handle platform eol-style in propedit. Also makes
> >> --encoding work for propedit.
> >>
> The log message could be improved; what does "Also makes --encoding
> work for propedit" mean? I think it means that the encoding is used
> for the temporary file, but it not obvious (to me) from the log
> message. That's a behaviour change that should be described.
>
"make ... work" meant a bugfix actually. The --encoding was used when
reading the edited file, but the system encoding was used when writing it.
Hope I've clarified this in the current log message.
> How about propget, does that need to handle --encoding to be
> consistent with propedit?
>
Maybe, but that's a new feature. I want these bugfixes in 1.1. Currently,
we don't have --encoding for propget.
OTOH, we have --encoding for the commands that commit, but in that case it
doesn't use the encoding when invoking the editor. Maybe it should, but
then we need to consider if the log-encoding configuration value should be
exactly equivalent to the --encoding argument. That would be a change in
the meaning of that configuration parameter that probably could break
something.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r11233 - trunk/subversion/clients/cmdline
Posted by Philip Martin <ph...@codematters.co.uk>.
"Peter N. Lundblad" <pe...@famlundblad.se> writes:
> On Mon, 4 Oct 2004 lundblad@tigris.org wrote:
>
>> Author: lundblad
>> Date: Mon Oct 4 15:01:33 2004
>> New Revision: 11233
>>
>> Modified:
>> trunk/subversion/clients/cmdline/cl.h
>> trunk/subversion/clients/cmdline/propedit-cmd.c
>> trunk/subversion/clients/cmdline/util.c
>> Log:
>> Fix issue #2063: handle platform eol-style in propedit. Also makes
>> --encoding work for propedit.
>>
> This needs to be verified by someone on Win32. It should fix the eol
> problem.
The log message could be improved; what does "Also makes --encoding
work for propedit" mean? I think it means that the encoding is used
for the temporary file, but it not obvious (to me) from the log
message. That's a behaviour change that should be described.
How about propget, does that need to handle --encoding to be
consistent with propedit?
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org