You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2023/02/25 23:10:47 UTC

[GitHub] [druid] clintropolis commented on a diff in pull request #13845: Add missing license for jakarta.activation against module druid-avro-extensions

clintropolis commented on code in PR #13845:
URL: https://github.com/apache/druid/pull/13845#discussion_r1117991921


##########
.github/workflows/static-checks.yml:
##########
@@ -56,7 +56,7 @@ jobs:
       - name: packaging check
         run: |
           ./.github/scripts/setup_generate_license.sh
-          ${MVN} clean install -Prat -Pbundle-contrib-exts --fail-at-end \

Review Comment:
   im not sure we should remove it, the packaging check was added to make sure that everything builds correctly, including contrib extensions (at least that is how i remember it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org