svn commit: r979683 - /tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ModelBuilderImpl.java

[sl...@apache.org]

Author: slaws
Date: Tue Jul 27 12:51:14 2010
New Revision: 979683

URL: http://svn.apache.org/viewvc?rev=979683&view=rev
Log:
Correct comment

Modified:
    tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ModelBuilderImpl.java

Modified: tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ModelBuilderImpl.java
URL: http://svn.apache.org/viewvc/tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ModelBuilderImpl.java?rev=979683&r1=979682&r2=979683&view=diff
==============================================================================
--- tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ModelBuilderImpl.java (original)
+++ tuscany/sca-java-2.x/trunk/modules/builder/src/main/java/org/apache/tuscany/sca/builder/impl/ModelBuilderImpl.java Tue Jul 27 12:51:14 2010
@@ -97,15 +97,14 @@ public class ModelBuilderImpl implements
             composite = compositeIncludeBuilder.build(composite, context);
 
             // Set up the structural URIs for components (services/references/bindings)
-            // TODO does this need to happen before policy attachment
             composite = structuralURIBuilder.build(composite, context);
             
             // Apply policy external attachment. Happens before the composite type
             // is created so that suitable promotion and structural processing is
             // applied to the attached policies
-            // TODO - I don't think this is correct. The policy spec (4.12.1)implies that
-            //        policy attachment happens independently of implementation or 
-            //        structural inheritance
+            // TODO - Can you attach a policy to a component and have it promoted to the 
+            //        components services and references. If yes this call is in the 
+            //        right place
             composite = policyAttachmentBuilder.build(composite, context);
 
             // Process the implementation hierarchy by calculating the component type