You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "harinreddy (Code Review)" <ge...@cloudera.org> on 2022/09/19 03:12:03 UTC
[kudu-CR] Adds HAS CLMUL to control inclusion of HW carryless multiply
harinreddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19011
Change subject: Adds HAS_CLMUL to control inclusion of HW carryless multiply
......................................................................
Adds HAS_CLMUL to control inclusion of HW carryless multiply
Some architectures do not support hardware implementation of
carryless multiply. Current code does not skip the HW
implementation-based code for architectures
which do not support carryless multiply instructions in hardware.
To fix this a preprocessor flag, HAS_CLMUL is defined.
If HAS_CLMUL is not set HW carryless multiply based code
is not included.
modified: src/kudu/common/columnar_serialization.cc
modified: src/kudu/common/zp7.cc
modified: src/kudu/common/zp7.h
Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
---
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/zp7.cc
M src/kudu/common/zp7.h
3 files changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/19011/1
--
To view, visit http://gerrit.cloudera.org:8080/19011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
Gerrit-Change-Number: 19011
Gerrit-PatchSet: 1
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
[kudu-CR] Adds HAS CLMUL to control inclusion of HW carryless multiply
Posted by "harinreddy (Code Review)" <ge...@cloudera.org>.
harinreddy has abandoned this change. ( http://gerrit.cloudera.org:8080/19011 )
Change subject: Adds HAS_CLMUL to control inclusion of HW carryless multiply
......................................................................
Abandoned
This patch is abandoned since a new patch is created
incorporating the recommended changes
https://gerrit.cloudera.org/#/c/19446/
--
To view, visit http://gerrit.cloudera.org:8080/19011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
Gerrit-Change-Number: 19011
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] Adds HAS CLMUL to control inclusion of HW carryless multiply
Posted by "harinreddy (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19011
to look at the new patch set (#2).
Change subject: Adds HAS_CLMUL to control inclusion of HW carryless multiply
......................................................................
Adds HAS_CLMUL to control inclusion of HW carryless multiply
Some architectures do not support hardware implementation of
carryless multiply. Current code does not skip the HW
implementation-based code for architectures
which do not support carryless multiply instructions in hardware.
To fix this a preprocessor flag, HAS_CLMUL is defined.
If HAS_CLMUL is not set HW carryless multiply based code
is not included.
modified: src/kudu/common/columnar_serialization.cc
modified: src/kudu/common/zp7.cc
modified: src/kudu/common/zp7.h
Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
---
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/zp7.cc
M src/kudu/common/zp7.h
3 files changed, 27 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/19011/2
--
To view, visit http://gerrit.cloudera.org:8080/19011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
Gerrit-Change-Number: 19011
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] Adds HAS CLMUL to control inclusion of HW carryless multiply
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19011 )
Change subject: Adds HAS_CLMUL to control inclusion of HW carryless multiply
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19011/2/src/kudu/common/columnar_serialization.cc
File src/kudu/common/columnar_serialization.cc:
http://gerrit.cloudera.org:8080/#/c/19011/2/src/kudu/common/columnar_serialization.cc@29
PS2, Line 29: #ifndef HAS_CLMUL
: #if defined (__x86_64__) || defined (_aarch64__)
: #define HAS_CLMUL
: #endif
: #endif
I think this sort of extra macro should be added via $KUDU_HOME/CMakeLists.txt instead of duplicating this logic in every file that has some relevant code.
See add_definitions() $KUDU_HOME/CMakeLists.txt for an example/reference.
--
To view, visit http://gerrit.cloudera.org:8080/19011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a4c9dde78530186bf25c1ecb4a0120c93f00fd
Gerrit-Change-Number: 19011
Gerrit-PatchSet: 2
Gerrit-Owner: harinreddy <hn...@us.ibm.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 17 Jan 2023 02:38:45 +0000
Gerrit-HasComments: Yes