[GitHub] [iceberg] wg1026688210 commented on a change in pull request #2932: delete file by mistake when rewriting iceberg table throw CommitStateUnknownException

[GitBox <gi...@apache.org>]

wg1026688210 commented on a change in pull request #2932:
URL: https://github.com/apache/iceberg/pull/2932#discussion_r684579028



##########
File path: core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -252,7 +254,6 @@ public RewriteDataFilesActionResult execute() {
     return new RewriteDataFilesActionResult(currentDataFiles, addedDataFiles);
   }
 
-

Review comment:
       > Yeah this is definitely the right thing to do, we are handling this in the new code (
   > 
   > https://github.com/apache/iceberg/blob/a1bd63d56751999ecee89b871992d7bac395fd52/core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java#L97-L109
   > 
   > ) as well and while this path is deprecated now I think we should definitely fix it to avoid causing issues while the path is still available.
   
   looking forward to using the new version rewrite




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org