You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by pi...@apache.org on 2021/12/14 02:01:50 UTC

[submarine] branch master updated: SUBMARINE-1122. Job "Build submarine quickstart" failed in github actions

This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 2e49def  SUBMARINE-1122. Job "Build submarine quickstart" failed in github actions
2e49def is described below

commit 2e49defe342b6566c4af75cb8e3a9d35e7906757
Author: MortalHappiness <b0...@ntu.edu.tw>
AuthorDate: Mon Dec 13 20:42:09 2021 +0800

    SUBMARINE-1122. Job "Build submarine quickstart" failed in github actions
    
    ### What is this PR for?
    Job "Build submarine quickstart" failed in recent github actions
    
    ![](https://issues.apache.org/jira/secure/attachment/13037195/image-2021-12-09-23-00-21-233.png)
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1122
    
    ### How should this be tested?
    
    Before this PR, running `./dev-support/examples/quickstart/build.sh` will fail due to the python version is too new in the docker image "continuumio/anaconda3". This PR uses the image "python:3.7" so that the above build command will succeed.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Do the license files need updating? No
    * Are there breaking changes for older versions? No
    * Does this need new documentation? No
    
    Author: MortalHappiness <b0...@ntu.edu.tw>
    
    Signed-off-by: Kevin <pi...@apache.org>
    
    Closes #830 from MortalHappiness/SUBMARINE-1122 and squashes the following commits:
    
    58ad4062 [MortalHappiness] SUBMARINE-1122. Fix build submarine quickstart failed
---
 dev-support/examples/quickstart/Dockerfile | 6 +++---
 website/docs/gettingStarted/quickstart.md  | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/dev-support/examples/quickstart/Dockerfile b/dev-support/examples/quickstart/Dockerfile
index ee6d66d..5ce1045 100644
--- a/dev-support/examples/quickstart/Dockerfile
+++ b/dev-support/examples/quickstart/Dockerfile
@@ -13,12 +13,12 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM continuumio/anaconda3
+FROM python:3.7
 MAINTAINER Apache Software Foundation <de...@submarine.apache.org>
 
 ADD ./tmp/submarine-sdk /opt/
 # install submarine-sdk locally
-RUN pip install /opt/pysubmarine/.[tf-latest] 
+RUN pip install /opt/pysubmarine/.[tf2]
 RUN pip install tensorflow_datasets
 
-ADD ./train.py /opt/
\ No newline at end of file
+ADD ./train.py /opt/
diff --git a/website/docs/gettingStarted/quickstart.md b/website/docs/gettingStarted/quickstart.md
index 566dfe2..b5e3e4b 100644
--- a/website/docs/gettingStarted/quickstart.md
+++ b/website/docs/gettingStarted/quickstart.md
@@ -182,6 +182,7 @@ if __name__ == '__main__':
 Build a docker image equipped with the requirement of the environment.
 
 ```bash
+eval $(minikube docker-env)
 ./dev-support/examples/quickstart/build.sh
 ```
 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org